You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/05/01 22:40:00 UTC
[jira] [Work logged] (BEAM-9136) Add LICENSES and NOTICES to docker
images
[ https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=429700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429700 ]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/20 22:39
Start Date: 01/May/20 22:39
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on a change in pull request #11584:
URL: https://github.com/apache/beam/pull/11584#discussion_r418766264
##########
File path: website/src/contribute/release-guide.md
##########
@@ -688,8 +688,20 @@ Verify that files are [present](https://dist.apache.org/repos/dist/dev/beam).
* Build Python images and push to DockerHub.
```
-./gradlew :sdks:python:container:buildAll -Pdocker-tag=${RELEASE}_rc{RC_NUM}
+./gradlew :sdks:python:container:buildAll -Pdocker-pull-licenses -Pdocker-tag=${RELEASE}_rc{RC_NUM}
+```
+
+Verify that third party licenses are included by logging in to the images. For Python SDK images, there should be around 80 ~ 100 dependencies.
+Please note that dependencies for the SDKs with different Python versions vary.
+Need to verify all Python images by replacing `${ver}` in the following command to `python2.7, python3.5, python3.6, python3.7`.
Review comment:
@ibzib , this part should be verified BEFORE pushing Python images. I'm not sure when this PR can be merged because of website issues, so explicitly pinging you here.
##########
File path: website/src/contribute/release-guide.md
##########
@@ -699,7 +711,18 @@ done
* Build Java images and push to DockerHub.
```
-./gradlew :sdks:java:container:dockerPush -Pdocker-pull-licenses -Pdocker-tag=${RELEASE}_rc{RC_NUM}
+./gradlew :sdks:java:container:docker -Pdocker-pull-licenses -Pdocker-tag=${RELEASE}_rc{RC_NUM}
+```
+
+Verify that third party licenses are included by logging in to the images. For Java SDK images, there should be around 1400 dependencies.
+```
+docker run -it --entrypoint=/bin/bash apache/beam_java_sdk:${RELEASE}_rc{RC_NUM}
+ls -al /opt/apache/beam/third_party_licenses/ | wc -l
+```
+
+After verifying the third party licenses are included correctly, push the images to DockerHub.
+```
Review comment:
@ibzib , this part changed slightly. Please note the change from `dockerPush` to `docker` at L714.
After creating the Java image, we should verify it BEFORE pushing to DockerHub. I'm not sure when this PR can be merged because of website issues, so explicitly pinging you here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 429700)
Time Spent: 28h 50m (was: 28h 40m)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 28h 50m
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)