You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by MichaelChirico <gi...@git.apache.org> on 2018/09/11 10:31:43 UTC
[GitHub] spark pull request #22393: Axe deprecated doc refs
GitHub user MichaelChirico opened a pull request:
https://github.com/apache/spark/pull/22393
Axe deprecated doc refs
Continuation of #22370. Summary of discussion there:
There is some inconsistency in the R manual w.r.t. supercedent functions linking back to deprecated functions.
- `createOrReplaceTempView` and `createTable` both link back to functions which are deprecated (`registerTempTable` and `createExternalTable`, respectively)
- `sparkR.session` and `dropTempView` do _not_ link back to deprecated functions
This PR takes the view that it is preferable _not_ to link back to deprecated functions, and removes these references from `?createOrReplaceTempView` and `?createTable`.
As `registerTempTable` was included in the `SparkDataFrame functions` `@family` of functions, other documentation pages which included a link to `?registerTempTable` will similarly be altered.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MichaelChirico/spark axe_deprecated_doc_refs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22393
----
commit e8b0d6333a1c09787e1c37a6f91eb895dee8fa72
Author: Michael Chirico <mi...@...>
Date: 2018-09-09T05:12:27Z
don't link to deprecated function
Seems misleading to (without qualification) link to a deprecated function
commit 41d6e26de5bb5b546710db51ce278bdd6182434a
Author: Michael Chirico <mi...@...>
Date: 2018-09-11T10:22:45Z
remove deprecated registerTempTable from SparkDataFrame functions family
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22393
**[Test build #96064 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96064/testReport)** for PR 22393 at commit [`41d6e26`](https://github.com/apache/spark/commit/41d6e26de5bb5b546710db51ce278bdd6182434a).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: Axe deprecated doc refs
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22393
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by MichaelChirico <gi...@git.apache.org>.
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22393
@felixcheung done
<img width="1018" alt="screen shot 2018-09-16 at 3 15 06 pm" src="https://user-images.githubusercontent.com/7606389/45593911-617ad000-b9c3-11e8-892a-4690396b66a1.png">
<img width="1021" alt="screen shot 2018-09-16 at 3 16 00 pm" src="https://user-images.githubusercontent.com/7606389/45593914-73f50980-b9c3-11e8-93be-842012cbdafe.png">
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22393
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22393
**[Test build #96064 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96064/testReport)** for PR 22393 at commit [`41d6e26`](https://github.com/apache/spark/commit/41d6e26de5bb5b546710db51ce278bdd6182434a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: Axe deprecated doc refs
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22393
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: Axe deprecated doc refs
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22393
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22393
yes please - please double the doc created looks correct - there is no automatic test for that
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: Axe deprecated doc refs
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22393
CC @felixcheung
I'd also prefix the title with `[MINOR][DOCS]` to match our conventions
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22393
could you check the doc output manually for registerTempTable and createTable?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22393
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by MichaelChirico <gi...@git.apache.org>.
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22393
@felixcheung is that to me?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22393
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22393
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96064/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/22393
thx. merged to master/2.4
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22393: [MINOR][DOCS] Axe deprecated doc refs
Posted by MichaelChirico <gi...@git.apache.org>.
Github user MichaelChirico commented on the issue:
https://github.com/apache/spark/pull/22393
@srowen thanks; done
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org