You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/18 20:30:00 UTC
[jira] [Work logged] (KNOX-2127) ZooKeeperAliasService mishandles
mixed-case alias keys properly
[ https://issues.apache.org/jira/browse/KNOX-2127?focusedWorklogId=345565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345565 ]
ASF GitHub Bot logged work on KNOX-2127:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/19 20:29
Start Date: 18/Nov/19 20:29
Worklog Time Spent: 10m
Work Description: pzampino commented on pull request #202: KNOX-2127 - ZooKeeperAliasService mishandles mixed-case alias keys pr…
URL: https://github.com/apache/knox/pull/202
…operly
## What changes were proposed in this pull request?
ZookeeperRemoteAliasService is modified to treat alias keys consistently wrt case, lower-casing them when aliases are added (used to only lower-case when values were looked up).
## How was this patch tested?
Modified ZookeeperRemoteAliasServiceTest to include a mixed-case alias key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 345565)
Remaining Estimate: 0h
Time Spent: 10m
> ZooKeeperAliasService mishandles mixed-case alias keys properly
> ---------------------------------------------------------------
>
> Key: KNOX-2127
> URL: https://issues.apache.org/jira/browse/KNOX-2127
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.3.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The ZooKeeperAliasService mishandles mixed-case alias keys. Due to JDK-4891485, the getPasswordFromAliasForCluster(String, String, boolean) implementation assumes the alias key should be lower-cased. However, it enforces no such requirement when an alias is added. Hence, it's possible to add a mixed-case alias key, but impossible to retrieve the value thereof.
> If this lower-case requirement is necessary, then the implementation must enforce it consistently. The add methods must also lower-case the alias keys.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)