You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/08 13:18:27 UTC

[GitHub] [arrow-rs] Marwes opened a new pull request, #2363: refactor: Group metrics into page and column metrics structs

Marwes opened a new pull request, #2363:
URL: https://github.com/apache/arrow-rs/pull/2363

   # Rationale for this change
    
   Refactors the metrics fields into sub-structs. Originally this was also supposed to reduce how much generic code were instantiated in `make_typed_statistics` but that method seems to have been removed. So now this is just a refactor.
   
   # What changes are included in this PR?
   
   Moves fields related to page/column metrics into newly added structs for clarity.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold merged pull request #2363: refactor: Group metrics into page and column metrics structs

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2363:
URL: https://github.com/apache/arrow-rs/pull/2363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] ursabot commented on pull request #2363: refactor: Group metrics into page and column metrics structs

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2363:
URL: https://github.com/apache/arrow-rs/pull/2363#issuecomment-1208209041

   Benchmark runs are scheduled for baseline = 9a630a10980aec65b045e59ca7c412c79eb07f65 and contender = 0c296ab619cbdd2479bb8ab30073e1de71f27b57. 0c296ab619cbdd2479bb8ab30073e1de71f27b57 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/fadac72cc6ef4dabbb164ca2511dfdad...c1895680e3bb40f9a8743d50eb4b8343/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9c477878ba8042a181b6289f1f40a857...3cdebb01bb414d7ebc01ef287954ca26/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/991f4abaabe9457a90f48bc326f32474...8853272eab034d6c91fdc7a9556b7f77/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6d3b1a45dfff47a6813063261d0f7c15...2de4daa720674facac89403990c99189/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org