You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/19 18:30:55 UTC

[GitHub] [spark] MaxGekk opened a new pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

MaxGekk opened a new pull request #32240:
URL: https://github.com/apache/spark/pull/32240


   ### What changes were proposed in this pull request?
   1. Add a test to check that Thrift server is able to collect year-month intervals and transfer them via thrift protocol.
   2. Improve similar test for day-time intervals. After the changes, the test doesn't depend on the result of date subtractions. In the future, the type of date subtract can be changed. So, current PR should make the test tolerant to the changes. 
   
   ### Why are the changes needed?
   To improve test coverage.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   By running the modified test suite:
   ```
   $ ./build/sbt -Phive -Phive-thriftserver "test:testOnly *SparkThriftServerProtocolVersionsSuite"
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32240:
URL: https://github.com/apache/spark/pull/32240#issuecomment-822744626






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32240:
URL: https://github.com/apache/spark/pull/32240#issuecomment-822702682


   **[Test build #137645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137645/testReport)** for PR 32240 at commit [`e01c650`](https://github.com/apache/spark/commit/e01c6500de299ce25d45b09ad5f994da72b8267c).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32240:
URL: https://github.com/apache/spark/pull/32240#issuecomment-822732559


   **[Test build #137645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137645/testReport)** for PR 32240 at commit [`e01c650`](https://github.com/apache/spark/commit/e01c6500de299ce25d45b09ad5f994da72b8267c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32240:
URL: https://github.com/apache/spark/pull/32240#issuecomment-822735990






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32240:
URL: https://github.com/apache/spark/pull/32240


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32240:
URL: https://github.com/apache/spark/pull/32240#issuecomment-822992928


   Merging to master. Thank you, @HyukjinKwon @yaooqinn for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32240:
URL: https://github.com/apache/spark/pull/32240#issuecomment-822744626






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32240:
URL: https://github.com/apache/spark/pull/32240#issuecomment-822685923


   This PR is similar to https://github.com/apache/spark/pull/32121 from test point of view. It became possible after https://github.com/apache/spark/pull/32209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32240: [SPARK-35018][SQL][TESTS] Check transferring of year-month intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32240:
URL: https://github.com/apache/spark/pull/32240#issuecomment-822702682


   **[Test build #137645 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137645/testReport)** for PR 32240 at commit [`e01c650`](https://github.com/apache/spark/commit/e01c6500de299ce25d45b09ad5f994da72b8267c).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org