You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/08 21:25:36 UTC

[GitHub] [spark] sunchao commented on a change in pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

sunchao commented on a change in pull request #31524:
URL: https://github.com/apache/spark/pull/31524#discussion_r572383191



##########
File path: docs/sql-ref-syntax-ddl-drop-table.md
##########
@@ -26,6 +26,8 @@ if the table is not `EXTERNAL` table. If the table is not present it throws an e
 
 In case of an external table, only the associated metadata information is removed from the metastore database.
 
+If the table is cached, the command uncaches the table and all its dependants such as views. Thereby the dependants should be cached again explicitly.

Review comment:
       nit: dependants -> dependents 

##########
File path: docs/sql-ref-syntax-ddl-alter-view.md
##########
@@ -28,6 +28,8 @@ the name of a view to a different name, set and unset the metadata of the view b
 Renames the existing view. If the new view name already exists in the source database, a `TableAlreadyExistsException` is thrown. This operation
 does not support moving the views across databases.
 
+If the view is cached, the command clears cached data of the view and all its dependents that refer to it. View's cache will be lazily filled when the next time the view or the dependents are accessed. The command leaves view's dependents as uncached.

Review comment:
       Hmm is this correct? should we say "The view's cache will be lazily filled when the next time it is accessed"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org