You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "wes3 (via GitHub)" <gi...@apache.org> on 2023/11/03 18:10:18 UTC
[PR] kernel/os: Add default irq callback [mynewt-core]
wes3 opened a new pull request, #3100:
URL: https://github.com/apache/mynewt-core/pull/3100
Added a MYNEWT_VAL named OS_DEFAULT_IRQ_CB which, when enabled, will call a user-defined callback as the first function called in os_default_irq(). This will allow users to define custom functionality when a default irq occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] kernel/os: Add default irq callback [mynewt-core]
Posted by "wes3 (via GitHub)" <gi...@apache.org>.
wes3 merged PR #3100:
URL: https://github.com/apache/mynewt-core/pull/3100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] kernel/os: Add default irq callback [mynewt-core]
Posted by "wes3 (via GitHub)" <gi...@apache.org>.
wes3 commented on PR #3100:
URL: https://github.com/apache/mynewt-core/pull/3100#issuecomment-1792914860
@benmccrea @andrzej-kaczmarek BTW: I should mention that this PR came about due to the hal_watchdog_tickle() issue for dialog mcu's wiping out the reset reason. I did not want to mess with the os_coredump_cb as was mentioned in that other PR which was closed. I wanted this to be called as the first function in os_default_irq() and be independent of the other MYNEWT_VALs. I only added this to os_fault.c in cm33 as I wanted to see what others thought about this and if desired we can add it to the other os_fault.c modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] kernel/os: Add default irq callback [mynewt-core]
Posted by "wes3 (via GitHub)" <gi...@apache.org>.
wes3 commented on PR #3100:
URL: https://github.com/apache/mynewt-core/pull/3100#issuecomment-1802943603
@andrzej-kaczmarek Honestly, I am not the biggest fan of this myself but I was having a hard time thinking of a better way to do this. The only other thought that came to mind was to replace the NMI irq for dialog mcu's. Currently, os_arch_arm.c installs the default irq by doing a NVIC_SetVector. I would need to look at the order at which things are done but maybe this could be done after os_arch_os_init() is called in some dialog specific code. That is my only other thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] kernel/os: Add default irq callback [mynewt-core]
Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek commented on PR #3100:
URL: https://github.com/apache/mynewt-core/pull/3100#issuecomment-1802833503
I'm not a big fan of this, but I won't oppose it since I don't have any better idea ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org