You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/03/25 09:03:48 UTC

svn commit: r1827701 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/Predictor.java

Author: tilman
Date: Sun Mar 25 09:03:48 2018
New Revision: 1827701

URL: http://svn.apache.org/viewvc?rev=1827701&view=rev
Log:
PDFBOX-4071: Sonar fix: put delcarations on separate lines; remove uneeded (); remove unneeded method

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/Predictor.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/Predictor.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/Predictor.java?rev=1827701&r1=1827700&r2=1827701&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/Predictor.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/filter/Predictor.java Sun Mar 25 09:03:48 2018
@@ -308,7 +308,10 @@ public final class Predictor
         // current predictor type
         private int predictor;
         // image decode parameters
-        private final int colors, bitsPerComponent, columns, rowLength;
+        private final int colors;
+        private final int bitsPerComponent;
+        private final int columns;
+        private final int rowLength;
         // PNG predictor (predictor>=10) means every row has a (potentially different)
         // predictor value
         private final boolean predictorPerRow;
@@ -328,7 +331,7 @@ public final class Predictor
             this.bitsPerComponent = bitsPerComponent;
             this.columns = columns;
             this.rowLength = calculateRowLength(colors, bitsPerComponent, columns);
-            this.predictorPerRow = (predictor >= 10);
+            this.predictorPerRow = predictor >= 10;
             currentRow = new byte[rowLength];
             lastRow = new byte[rowLength];
         }
@@ -404,12 +407,6 @@ public final class Predictor
         }
 
         @Override
-        public void close() throws IOException
-        {
-            super.close();
-        }
-
-        @Override
         public void write(int i) throws IOException
         {
             throw new UnsupportedOperationException("Not supported");