[jira] [Commented] (STORM-1992) Deploy multilang-javascript code as node package

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388539#comment-15388539 ] 

ASF GitHub Bot commented on STORM-1992:
---------------------------------------

GitHub user mzbyszynski opened a pull request:

    https://github.com/apache/storm/pull/1584

    STORM-1992 Added artifacts to make storm.js into an npm package

    Posting for feedback! Please let me know if I am on the right track. This PR relates to [STORM-1992](https://issues.apache.org/jira/browse/STORM-1992)
    
    ```bash
    $ mvn deploy -P npmjs
    ```
    Would publish the package to npmjs.com as **storm-multilang-js** (I could not think of a better name that was not taken) along with the other deployments the build performs. It would have be manually executed right now because you need to have run `npm login` before hand to enter your credentials. I have not found a clean way to make this automated, but if that is a requirement I can probably get it working in an unclean way.
    
    I published the package with a bogus version number here as an example: https://www.npmjs.com/package/storm-multilang-js
    
    I added a `stormjs` utility to make it easier to call a js spout or bolt from a topology by taking care of some of the boilerplate. I also cleaned up `storm.js` a little bit by adding missing semi-colons and making string quotation consistent.
    
    I'm unsure about the README.md file for the npm package. Should I add more to it or should it just point to documentation living somewhere else?
    
    Thank you!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mzbyszynski/storm STORM-1992_multilang_js_npm

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1584.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1584
    
----
commit afe5e3e4db519ea5877c6e9a7c5b2da668784814
Author: Marc Zbyszynski <mz...@xlhybrids.com>
Date:   2016-07-21T21:55:57Z

    STORM-1992 Added artifacts to multilang-javascript to package it as an npm module, and added npmjs profile for deploying the package to npmjs.con

----


> Deploy multilang-javascript code as node package
> ------------------------------------------------
>
>                 Key: STORM-1992
>                 URL: https://issues.apache.org/jira/browse/STORM-1992
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-multilang
>    Affects Versions: 1.0.1
>            Reporter: Marc Zbyszynski
>            Priority: Minor
>
> Now that storm includes Flux, it is easier than ever to deploy a topology with javascript components. If the Bolt and Spout base classes defined in storm/multi-lang/javascript were available in a node.js package on https://www.npmjs.com/ it would allow node.js storm users to take advantage of node's built in package manager to develop their own bolts and spouts.
> It would be relatively trivial to add some maven tasks to storm/multi-lang/javascript/pom.xml to take the storm.js resource and package it in a node module and submit it to npm.
> This could be added to the pom as a separate profile so it wouldn't impact the normal storm build process.
> This integration will also make it easier to add unit tests for storm.js
> For additional background see this discussion: 
> http://mail-archives.apache.org/mod_mbox/storm-dev/201607.mbox/%3CCAD8EKPHc6O1LCnoQUUoYoDuMQ3uSaNpD5gR4onK%2B0EL5_qcZ3Q%40mail.gmail.com%3E
> If this sounds like a worthwhile addition to the project I would be happy to submit a PR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)