You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2016/03/25 22:27:55 UTC
incubator-kudu git commit: client: add APIs to fetch version info
Repository: incubator-kudu
Updated Branches:
refs/heads/master 1ad79bccd -> e317be64f
client: add APIs to fetch version info
This adds some simple APIs which return the build version info.
This is useful for example in Impala where we might want to include
the Kudu client version in debug info, etc.
Change-Id: I19352889f348111e262581974a54143275108286
Reviewed-on: http://gerrit.cloudera.org:8080/2631
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/e317be64
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/e317be64
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/e317be64
Branch: refs/heads/master
Commit: e317be64f9f449621af17e476e1485e5fa783a82
Parents: 1ad79bc
Author: Todd Lipcon <to...@apache.org>
Authored: Fri Mar 25 12:44:20 2016 -0700
Committer: Todd Lipcon <to...@apache.org>
Committed: Fri Mar 25 21:27:41 2016 +0000
----------------------------------------------------------------------
src/kudu/client/client.cc | 9 +++++++++
src/kudu/client/client.h | 7 +++++++
src/kudu/client/samples/sample.cc | 5 +++++
3 files changed, 21 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/e317be64/src/kudu/client/client.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/client.cc b/src/kudu/client/client.cc
index 862e459..650216e 100644
--- a/src/kudu/client/client.cc
+++ b/src/kudu/client/client.cc
@@ -53,6 +53,7 @@
#include "kudu/util/init.h"
#include "kudu/util/logging.h"
#include "kudu/util/net/dns_resolver.h"
+#include "kudu/util/version_info.h"
using kudu::master::AlterTableRequestPB;
using kudu::master::AlterTableRequestPB_Step;
@@ -163,6 +164,14 @@ Status SetInternalSignalNumber(int signum) {
return SetStackTraceSignal(signum);
}
+std::string GetShortVersionString() {
+ return VersionInfo::GetShortVersionString();
+}
+
+std::string GetAllVersionInfo() {
+ return VersionInfo::GetAllVersionInfo();
+}
+
KuduClientBuilder::KuduClientBuilder()
: data_(new KuduClientBuilder::Data()) {
}
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/e317be64/src/kudu/client/client.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/client.h b/src/kudu/client/client.h
index 498c20e..88866ac 100644
--- a/src/kudu/client/client.h
+++ b/src/kudu/client/client.h
@@ -108,6 +108,13 @@ void KUDU_EXPORT SetVerboseLogLevel(int level);
// workaround conflicts.
Status KUDU_EXPORT SetInternalSignalNumber(int signum);
+// Return a single-version string identifying the Kudu client.
+std::string KUDU_EXPORT GetShortVersionString();
+
+// Return a longer multi-line version string identifying the client, including
+// build time, etc.
+std::string KUDU_EXPORT GetAllVersionInfo();
+
// Creates a new KuduClient with the desired options.
//
// Note that KuduClients are shared amongst multiple threads and, as such,
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/e317be64/src/kudu/client/samples/sample.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/samples/sample.cc b/src/kudu/client/samples/sample.cc
index 340d01c..73ef2b3 100644
--- a/src/kudu/client/samples/sample.cc
+++ b/src/kudu/client/samples/sample.cc
@@ -231,6 +231,11 @@ static void LogCb(void* unused,
}
int main(int argc, char* argv[]) {
+ KUDU_LOG(INFO) << "Running with Kudu client version: " <<
+ kudu::client::GetShortVersionString();
+ KUDU_LOG(INFO) << "Long version info: " <<
+ kudu::client::GetAllVersionInfo();
+
kudu::client::KuduLoggingFunctionCallback<void*> log_cb(&LogCb, NULL);
kudu::client::InstallLoggingCallback(&log_cb);