[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #5179: Fix decimal scalar dyn kernels

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #5179:
URL: https://github.com/apache/arrow-datafusion/pull/5179#discussion_r1096589323


##########
datafusion/physical-expr/src/expressions/binary/kernels_arrow.rs:
##########
@@ -189,28 +189,20 @@ pub(crate) fn add_decimal(
 }
 
 pub(crate) fn add_decimal_dyn_scalar(left: &dyn Array, right: i128) -> Result<ArrayRef> {
-    let left_decimal = left.as_any().downcast_ref::<Decimal128Array>().unwrap();
+    let (precision, scale) = get_precision_scale(left)?;

Review Comment:
   In last PR, forgot to update this and there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org