You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/01 22:00:57 UTC

[GitHub] [tvm] tqchen commented on a change in pull request #7385: [TIR] Add additional termination condition to For node to enable While loop like feature

tqchen commented on a change in pull request #7385:
URL: https://github.com/apache/tvm/pull/7385#discussion_r568169870



##########
File path: include/tvm/tir/stmt.h
##########
@@ -802,6 +802,9 @@ class ForNode : public StmtNode {
   ForKind kind;
   /*! \brief The body of the for loop. */
   Stmt body;
+  /*! \brief The additional termination condition of the for loop. */
+  Optional<PrimExpr> test;

Review comment:
       It would be helpful to have a RFC discussion, since different strategies changes to the IR can have different implications




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org