[jira] [Comment Edited] (HIVE-17069) Refactor OrcRawRecrodMerger.ReaderPair

["Eugene Koifman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091765#comment-16091765 ] 

Eugene Koifman edited comment on HIVE-17069 at 7/18/17 4:13 PM:
----------------------------------------------------------------

This patch only does refactoring - there are no logic changes.
OriginalReaderPairToCompact is used any time compaction runs so it's tested by any tests running compaction over a table that has original files. Previously there was just one OriginalReaderPair which handled both using if statements and obscure logic.

TestTxnCommands.testNonAcid2Acid* and TestTxnCommands2.testNonAcid2Acid* all cover this


was (Author: ekoifman):
This patch only does refactoring - there are no logic changes.
OriginalReaderPairToCompact is used any time compaction runs so it's tested by any tests running compaction over a table that has original files.

TestTxnCommands.testNonAcid2Acid* and TestTxnCommands2.testNonAcid2Acid* all cover this

> Refactor OrcRawRecrodMerger.ReaderPair
> --------------------------------------
>
>                 Key: HIVE-17069
>                 URL: https://issues.apache.org/jira/browse/HIVE-17069
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>         Attachments: HIVE-17069.01.patch, HIVE-17069.02.patch, HIVE-17069.03.patch
>
>
> this should be done post HIVE-16177 so as not to obscure the functional changes completely
> Make ReaderPair an interface
> ReaderPairImpl - will do what ReaderPair currently does, i.e. handle "normal" code path
> OriginalReaderPair - same as now but w/o incomprehensible override/variable shadowing logic.
> Perhaps split it into 2 - 1 for compaction 1 for "normal" read with common base class.
> Push discoverKeyBounds() into appropriate implementation



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)