You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/04/29 11:09:07 UTC
Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10836/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh Chaturvedi.
Description
-------
CLOUDSTACK-957: Localization -- Add UK keyboard support.
- Added the support of UK keyboard by:
- Initialising the UK keyboard from the existing US keyboard mapping.
- Adding/Overriding the special keys support of UK keys which differ from US keyboard.
- Also moved the JP keys initialisation to ajaxkeys.js file.
This addresses bug CLOUDSTACK-957.
Diffs
-----
services/console-proxy/server/css/ajaxviewer.css 5ea552b
services/console-proxy/server/js/ajaxkeys.js 2ecf5b5
services/console-proxy/server/js/ajaxviewer.js e95615d
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java 289bdab
Diff: https://reviews.apache.org/r/10836/diff/
Testing
-------
Tests:
1) Setup CS environment and deploy a VM (Windows7 preferred, as I have tested on this).
2) Go to VM detailView and open VM console view.
3) Change input method for keyboard to UK language.
4) Go to top of console-window and click on "keyboard" option to select UK language.
5) Start using UK keyboard (Make sure the input method of client keyboard is UK (from where the user is pressing the keys)).
Tested on my local CloudStack setup by following above mentioned steps.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10836/#review20292
-----------------------------------------------------------
Commit b6cb23cb99c9daee41b46a3fc13fffabfb791dc3 in branch refs/heads/master from Likitha Shetty <li...@citrix.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b6cb23c ]
CLOUDSTACK-957: Localization -- Add UK keyboard support.
- ASF Subversion and Git Services
On May 7, 2013, 8:06 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10836/
> -----------------------------------------------------------
>
> (Updated May 7, 2013, 8:06 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh Chaturvedi.
>
>
> Description
> -------
>
> CLOUDSTACK-957: Localization -- Add UK keyboard support.
>
> - Added the support of UK keyboard by:
> - Initialising the UK keyboard from the existing US keyboard mapping.
> - Adding/Overriding the special keys support of UK keys which differ from US keyboard.
> - Also moved the JP keys initialisation to ajaxkeys.js file.
>
>
> This addresses bug CLOUDSTACK-957.
>
>
> Diffs
> -----
>
> services/console-proxy/server/css/ajaxviewer.css 5ea552b
> services/console-proxy/server/js/ajaxkeys.js 2ecf5b5
> services/console-proxy/server/js/ajaxviewer.js e95615d
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java 289bdab
>
> Diff: https://reviews.apache.org/r/10836/diff/
>
>
> Testing
> -------
>
> Tests:
>
> 1) Setup CS environment and deploy a VM (Windows7 preferred, as I have tested on this).
> 2) Go to VM detailView and open VM console view.
> 3) Change input method for keyboard to UK language.
> 4) Go to top of console-window and click on "keyboard" option to select UK language.
> 5) Start using UK keyboard (Make sure the input method of client keyboard is UK (from where the user is pressing the keys)).
>
> Tested on my local CloudStack setup by following above mentioned steps.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10836/
-----------------------------------------------------------
(Updated May 7, 2013, 8:06 a.m.)
Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh Chaturvedi.
Changes
-------
Updated patch after resolving the conflicts with the latest code.
Description
-------
CLOUDSTACK-957: Localization -- Add UK keyboard support.
- Added the support of UK keyboard by:
- Initialising the UK keyboard from the existing US keyboard mapping.
- Adding/Overriding the special keys support of UK keys which differ from US keyboard.
- Also moved the JP keys initialisation to ajaxkeys.js file.
This addresses bug CLOUDSTACK-957.
Diffs (updated)
-----
services/console-proxy/server/css/ajaxviewer.css 5ea552b
services/console-proxy/server/js/ajaxkeys.js 2ecf5b5
services/console-proxy/server/js/ajaxviewer.js e95615d
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java 289bdab
Diff: https://reviews.apache.org/r/10836/diff/
Testing
-------
Tests:
1) Setup CS environment and deploy a VM (Windows7 preferred, as I have tested on this).
2) Go to VM detailView and open VM console view.
3) Change input method for keyboard to UK language.
4) Go to top of console-window and click on "keyboard" option to select UK language.
5) Start using UK keyboard (Make sure the input method of client keyboard is UK (from where the user is pressing the keys)).
Tested on my local CloudStack setup by following above mentioned steps.
Thanks,
Sanjay Tripathi
Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support
Posted by Sanjay Tripathi <sa...@citrix.com>.
> On May 3, 2013, 6:50 p.m., Fang Wang wrote:
> > In file ajaxkeys.js, the original lines 32-33, and 47-49 are deleted. Those are needed for handling the JP keyboards. Did you replace them with other key combinations? just make sure it won't break the JP keyboards.
> >
> > Thanks.
Fang,
The key modifier mask at location line 32- 33 are simply got moved to new line no.s 125 and 89 respectively.
Initially the mapping in the file ajaxkeys.js was not getting properly loaded, so after when i fixed that problem, the "open bracked", "close bracket" and "colon keys" in US keyboard were getting printed twice with only one stroke of the key and this was happening because these keys(line 47-49) were already initialized in the ajaxviewer.js and these entry in ajaxkeys.js were simply adding the initialization in the array. So I removed them(line 47-49) from ajaxkeys.js file.
- Sanjay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10836/#review20130
-----------------------------------------------------------
On April 29, 2013, 9:09 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10836/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 9:09 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh Chaturvedi.
>
>
> Description
> -------
>
> CLOUDSTACK-957: Localization -- Add UK keyboard support.
>
> - Added the support of UK keyboard by:
> - Initialising the UK keyboard from the existing US keyboard mapping.
> - Adding/Overriding the special keys support of UK keys which differ from US keyboard.
> - Also moved the JP keys initialisation to ajaxkeys.js file.
>
>
> This addresses bug CLOUDSTACK-957.
>
>
> Diffs
> -----
>
> services/console-proxy/server/css/ajaxviewer.css 5ea552b
> services/console-proxy/server/js/ajaxkeys.js 2ecf5b5
> services/console-proxy/server/js/ajaxviewer.js e95615d
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java 289bdab
>
> Diff: https://reviews.apache.org/r/10836/diff/
>
>
> Testing
> -------
>
> Tests:
>
> 1) Setup CS environment and deploy a VM (Windows7 preferred, as I have tested on this).
> 2) Go to VM detailView and open VM console view.
> 3) Change input method for keyboard to UK language.
> 4) Go to top of console-window and click on "keyboard" option to select UK language.
> 5) Start using UK keyboard (Make sure the input method of client keyboard is UK (from where the user is pressing the keys)).
>
> Tested on my local CloudStack setup by following above mentioned steps.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support
Posted by Fang Wang <fa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10836/#review20130
-----------------------------------------------------------
In file ajaxkeys.js, the original lines 32-33, and 47-49 are deleted. Those are needed for handling the JP keyboards. Did you replace them with other key combinations? just make sure it won't break the JP keyboards.
Thanks.
- Fang Wang
On April 29, 2013, 9:09 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10836/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 9:09 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh Chaturvedi.
>
>
> Description
> -------
>
> CLOUDSTACK-957: Localization -- Add UK keyboard support.
>
> - Added the support of UK keyboard by:
> - Initialising the UK keyboard from the existing US keyboard mapping.
> - Adding/Overriding the special keys support of UK keys which differ from US keyboard.
> - Also moved the JP keys initialisation to ajaxkeys.js file.
>
>
> This addresses bug CLOUDSTACK-957.
>
>
> Diffs
> -----
>
> services/console-proxy/server/css/ajaxviewer.css 5ea552b
> services/console-proxy/server/js/ajaxkeys.js 2ecf5b5
> services/console-proxy/server/js/ajaxviewer.js e95615d
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java 289bdab
>
> Diff: https://reviews.apache.org/r/10836/diff/
>
>
> Testing
> -------
>
> Tests:
>
> 1) Setup CS environment and deploy a VM (Windows7 preferred, as I have tested on this).
> 2) Go to VM detailView and open VM console view.
> 3) Change input method for keyboard to UK language.
> 4) Go to top of console-window and click on "keyboard" option to select UK language.
> 5) Start using UK keyboard (Make sure the input method of client keyboard is UK (from where the user is pressing the keys)).
>
> Tested on my local CloudStack setup by following above mentioned steps.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10836/#review20055
-----------------------------------------------------------
I don't understand this code completely and I may not be the right person to review these changes. Can someone else from the community look at this changes?
- Devdeep Singh
On April 29, 2013, 9:09 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10836/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 9:09 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh Chaturvedi.
>
>
> Description
> -------
>
> CLOUDSTACK-957: Localization -- Add UK keyboard support.
>
> - Added the support of UK keyboard by:
> - Initialising the UK keyboard from the existing US keyboard mapping.
> - Adding/Overriding the special keys support of UK keys which differ from US keyboard.
> - Also moved the JP keys initialisation to ajaxkeys.js file.
>
>
> This addresses bug CLOUDSTACK-957.
>
>
> Diffs
> -----
>
> services/console-proxy/server/css/ajaxviewer.css 5ea552b
> services/console-proxy/server/js/ajaxkeys.js 2ecf5b5
> services/console-proxy/server/js/ajaxviewer.js e95615d
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java 289bdab
>
> Diff: https://reviews.apache.org/r/10836/diff/
>
>
> Testing
> -------
>
> Tests:
>
> 1) Setup CS environment and deploy a VM (Windows7 preferred, as I have tested on this).
> 2) Go to VM detailView and open VM console view.
> 3) Change input method for keyboard to UK language.
> 4) Go to top of console-window and click on "keyboard" option to select UK language.
> 5) Start using UK keyboard (Make sure the input method of client keyboard is UK (from where the user is pressing the keys)).
>
> Tested on my local CloudStack setup by following above mentioned steps.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>
Re: Review Request: CLOUDSTACK-957: Localization -- Add UK keyboard support
Posted by Fang Wang <fa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10836/#review20209
-----------------------------------------------------------
Ship it!
Ship it!
- Fang Wang
On April 29, 2013, 9:09 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10836/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 9:09 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, Fang Wang, and Animesh Chaturvedi.
>
>
> Description
> -------
>
> CLOUDSTACK-957: Localization -- Add UK keyboard support.
>
> - Added the support of UK keyboard by:
> - Initialising the UK keyboard from the existing US keyboard mapping.
> - Adding/Overriding the special keys support of UK keys which differ from US keyboard.
> - Also moved the JP keys initialisation to ajaxkeys.js file.
>
>
> This addresses bug CLOUDSTACK-957.
>
>
> Diffs
> -----
>
> services/console-proxy/server/css/ajaxviewer.css 5ea552b
> services/console-proxy/server/js/ajaxkeys.js 2ecf5b5
> services/console-proxy/server/js/ajaxviewer.js e95615d
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java 289bdab
>
> Diff: https://reviews.apache.org/r/10836/diff/
>
>
> Testing
> -------
>
> Tests:
>
> 1) Setup CS environment and deploy a VM (Windows7 preferred, as I have tested on this).
> 2) Go to VM detailView and open VM console view.
> 3) Change input method for keyboard to UK language.
> 4) Go to top of console-window and click on "keyboard" option to select UK language.
> 5) Start using UK keyboard (Make sure the input method of client keyboard is UK (from where the user is pressing the keys)).
>
> Tested on my local CloudStack setup by following above mentioned steps.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>