[GitHub] [spark] cloud-fan commented on a diff in pull request #42740: [WIP][SPARK-45022][SQL] Provide context for dataset API errors

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42740:
URL: https://github.com/apache/spark/pull/42740#discussion_r1311670227


##########
sql/core/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -241,29 +249,35 @@ object functions {
    * @since 1.3.0
    */
   @deprecated("Use approx_count_distinct", "2.1.0")
-  def approxCountDistinct(e: Column): Column = approx_count_distinct(e)
+  def approxCountDistinct(e: Column): Column = withAggregateFunction {

Review Comment:
   since we need to touch a lot of functions anyway, here is a long-standing cleanup work that is not finished: most of the functions can be implemented by creating `UnresolvedFunction`. We don't need to create the function expression directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org