You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2023/01/04 21:58:42 UTC
[GitHub] [solr] janhoy opened a new pull request, #1272: Solr 16535 Remove jaegertracer-configurator module in 10.0
janhoy opened a new pull request, #1272:
URL: https://github.com/apache/solr/pull/1272
https://issues.apache.org/jira/browse/SOLR-16535
The plan is to merge #1270 only to `branch_9x` and merge this only to `main`. That's why I included the 9.2 changes line for SOLR-16534 here as well. Let me know if there you prefer it done differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1272: SOLR-16535 Remove jaegertracer-configurator module in 10.0
Posted by GitBox <gi...@apache.org>.
janhoy merged PR #1272:
URL: https://github.com/apache/solr/pull/1272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1272: Solr 16535 Remove jaegertracer-configurator module in 10.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1272:
URL: https://github.com/apache/solr/pull/1272#discussion_r1061919838
##########
solr/solr-ref-guide/modules/deployment-guide/pages/cluster-node-management.adoc:
##########
@@ -852,9 +849,8 @@ http://localhost:8983/solr/admin/collections?action=OVERSEERSTATUS
"95thPcRequestTime":0.519016,
"99thPcRequestTime":0.519016,
"999thPcRequestTime":0.519016},
- "removeshard",{
- "..."
- }],
+ "removeshard",{}
+ ],
Review Comment:
This is unrelated, I know, but for some reason gradle check failed due to invalid json, so I just made it valid. I touched this file to remove a line about jaeger, that's probably why it started validating in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1272: SOLR-16535 Remove jaegertracer-configurator module in 10.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1272:
URL: https://github.com/apache/solr/pull/1272#discussion_r1062994944
##########
versions.lock:
##########
@@ -239,7 +237,6 @@ org.apache.sis.core:sis-referencing:1.2 (3 constraints: 4829fae1)
org.apache.sis.core:sis-utility:1.2 (4 constraints: 0b35ce5b)
org.apache.sis.storage:sis-netcdf:1.2 (1 constraints: fc0b54e9)
org.apache.sis.storage:sis-storage:1.2 (1 constraints: df0de432)
-org.apache.thrift:libthrift:0.15.0 (1 constraints: 900d0334)
Review Comment:
Yey, finally this is gone :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1272: SOLR-16535 Remove jaegertracer-configurator module in 10.0
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1272:
URL: https://github.com/apache/solr/pull/1272#issuecomment-1372959927
This is now ready after some final edits, and addition of refGuide major-changes note for 10.0.
+21 lines and −1,084 lines. Love it :)
I'll merge whenever I get a +1 or if silent, on Tuesday 10th
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org