You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by stanlyxiang <gi...@git.apache.org> on 2017/01/16 07:47:16 UTC
[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...
GitHub user stanlyxiang opened a pull request:
https://github.com/apache/incubator-hawq/pull/1088
HAWQ-1276. The error message is not friendly when ranger plugin servi\u2026
\u2026ce is unavailable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyxiang/incubator-hawq HAWQ-1276
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1088.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1088
----
commit 865968af5058b52033b3a420ab4fc4bd55f0b3a9
Author: stanlyxiang <st...@gmail.com>
Date: 2017-01-13T03:33:40Z
HAWQ-1276. The error message is not friendly when ranger plugin service is unavailable.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1088: HAWQ-1276. The error message is not friendly whe...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1088
cc @interma @zhangh43 @linwen @ictmalili @wcl14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1088#discussion_r96179729
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -366,7 +365,7 @@ static size_t write_callback(char *contents, size_t size, size_t nitems,
if (curl->response.buffer == NULL)
{
/* out of memory! */
- elog(WARNING, "not enough memory for Ranger response");
+ elog(WARNING, "cannot allocate memory for ranger response");
--- End diff --
hmm, IMO , not enough memory is not the only error that will occur. There maybe other errors in the repalloc implementation. So I changed the messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1088: HAWQ-1276. The error message is not friendly whe...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1088
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1088
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1088: HAWQ-1276. The error message is not friendly whe...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1088
merged into master. closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...
Posted by wcl14 <gi...@git.apache.org>.
Github user wcl14 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1088#discussion_r96180237
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -366,7 +365,7 @@ static size_t write_callback(char *contents, size_t size, size_t nitems,
if (curl->response.buffer == NULL)
{
/* out of memory! */
- elog(WARNING, "not enough memory for Ranger response");
+ elog(WARNING, "cannot allocate memory for ranger response");
--- End diff --
So should the comment be consistent with the code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...
Posted by wcl14 <gi...@git.apache.org>.
Github user wcl14 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1088#discussion_r96178079
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -366,7 +365,7 @@ static size_t write_callback(char *contents, size_t size, size_t nitems,
if (curl->response.buffer == NULL)
{
/* out of memory! */
- elog(WARNING, "not enough memory for Ranger response");
+ elog(WARNING, "cannot allocate memory for ranger response");
--- End diff --
Why do you modify the out of memory error message. I think the original one is more specified, and may be better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1088#discussion_r96181179
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -366,7 +365,7 @@ static size_t write_callback(char *contents, size_t size, size_t nitems,
if (curl->response.buffer == NULL)
{
/* out of memory! */
- elog(WARNING, "not enough memory for Ranger response");
+ elog(WARNING, "cannot allocate memory for ranger response");
--- End diff --
sure. fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1088: HAWQ-1276. The error message is not frien...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1088#discussion_r96360891
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -294,7 +294,7 @@ static json_object *create_ranger_request_json(List *request_list, List *result_
break;
}
default:
- elog(ERROR, "unrecognized objkind: %d", (int) kind);
+ elog(ERROR, "unrecognized object kind : %d", (int) kind);
--- End diff --
since this is a message to users, we should map this "kind" to string, so that users can know which kind is not supported.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---