You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/08/30 17:21:23 UTC
[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1194:
HDDS-1879. Support multiple excluded scopes when choosing datanodes in
NetworkTopology
xiaoyuyao commented on a change in pull request #1194: HDDS-1879. Support multiple excluded scopes when choosing datanodes in NetworkTopology
URL: https://github.com/apache/hadoop/pull/1194#discussion_r319605573
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/InnerNodeImpl.java
##########
@@ -313,12 +314,12 @@ public Node getLeaf(int leafIndex) {
* means picking the 3th available node, which is n5.
Review comment:
It is not related to the current change. But the example in the comments need further clarification. E.g., n5 is under /dc2 which is in excludedScope. Maybe you want to put n5 under /root/dc1/rack2? instead of /root/dc2/rack1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org