You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Christian van der Leeden (JIRA)" <ji...@apache.org> on 2010/06/29 19:45:49 UTC
[jira] Created: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Cassandra AVRO api is missing system_add_column_family
------------------------------------------------------
Key: CASSANDRA-1238
URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.7
Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
Reporter: Christian van der Leeden
The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans reassigned CASSANDRA-1238:
-------------------------------------
Assignee: Eric Evans
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Assignee: Eric Evans
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1238:
--------------------------------------
Assignee: (was: Eric Evans)
Reviewer: urandom (was: eevans)
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Fix For: 0.7.0
>
> Attachments: 001-CASSANDRA-1238.patch
>
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-1238:
----------------------------------
Attachment: 002-CASSANDRA-1238-errata.patch
002-CASSANDRA-1238-errata.patch is just here to document the changes I made ontop of 002-CASSANDRA-1238.patch. This has been committed as one changeset.
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Fix For: 0.7.0
>
> Attachments: 001-CASSANDRA-1238.patch, 002-CASSANDRA-1238-errata.patch, 002-CASSANDRA-1238.patch
>
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898590#action_12898590 ]
Antoine Toulme commented on CASSANDRA-1238:
-------------------------------------------
Thanks Eric. I will rework the patch to follow Thrift, and will look at the python tests.
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Assignee: Eric Evans
> Fix For: 0.7.0
>
> Attachments: 001-CASSANDRA-1238.patch
>
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme updated CASSANDRA-1238:
--------------------------------------
Attachment: 002-CASSANDRA-1238.patch
Here is a second patch that brings a few new methods to the Avro API. It should cover quite a bit. All tests pass.
This patch is made against the current trunk and ready for review. Enjoy!
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Fix For: 0.7.0
>
> Attachments: 001-CASSANDRA-1238.patch, 002-CASSANDRA-1238.patch
>
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898502#action_12898502 ]
Eric Evans commented on CASSANDRA-1238:
---------------------------------------
First off, thanks for taking the time to work on this.
As for the patch, it would be better to model this method after the corresponding one in the Thrift version of CassandraServer, instead of add_system_keyspace().
The tests for this are written in Python and can be found in test/system/test_avro_server.py (let me know if you need help with this).
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Assignee: Eric Evans
> Fix For: 0.7.0
>
> Attachments: 001-CASSANDRA-1238.patch
>
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901014#action_12901014 ]
Hudson commented on CASSANDRA-1238:
-----------------------------------
Integrated in Cassandra #518 (See [https://hudson.apache.org/hudson/job/Cassandra/518/])
several new avro rpc method implementations
Patch by Antoine Toulme w/ some changes by eevans for CASSANDRA-1238
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Assignee: Antoine Toulme
> Fix For: 0.7.0
>
> Attachments: 001-CASSANDRA-1238.patch, 002-CASSANDRA-1238-errata.patch, 002-CASSANDRA-1238.patch
>
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme updated CASSANDRA-1238:
--------------------------------------
Attachment: 001-CASSANDRA-1238.patch
Here is a patch that adds this method. It adds the method to the Avro API by patching the Avro protocol and implements the method on CassandraServer, mostly by copy/pasting the code from add_system_keyspace, and using the AddColumnFamily migration to apply the change.
I could not find the tests you were referring to. I would be much more comfortable if that patch came with tests, but I could not spot them in the source code. If you would be so kind as to give me their location, I'd happily contribute tests for this change.
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Assignee: Eric Evans
> Fix For: 0.7.0
>
> Attachments: 001-CASSANDRA-1238.patch
>
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1238:
--------------------------------------
Fix Version/s: 0.7
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Assignee: Eric Evans
> Fix For: 0.7
>
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1238) Cassandra AVRO api is missing
system_add_column_family
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883631#action_12883631 ]
Eric Evans commented on CASSANDRA-1238:
---------------------------------------
Avro support is in-progress and considered experimental. There are still a number of unimplemented RPC methods.
That said, you can create column families and keyspaces at once using {{system_add_keyspace}} but supplying a list of CfDefs (see the system tests for an example of this).
> Cassandra AVRO api is missing system_add_column_family
> ------------------------------------------------------
>
> Key: CASSANDRA-1238
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1238
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7
> Environment: Mac OSX 10.6.4, Cassandra Trunk, Rev. 958403, java 1.6.0_20
> Reporter: Christian van der Leeden
> Assignee: Eric Evans
>
> The cassandra.avpr does contain the method system_add_keyspace but is missing the system_add_column_family.
> Workaround: have to revert to the thrift API to create column families.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.