[GitHub] [incubator-doris] dataroaring commented on a diff in pull request #9926: [feature](storage) rowset meta add tablet schema for future use

[GitBox <gi...@apache.org>]

dataroaring commented on code in PR #9926:
URL: https://github.com/apache/incubator-doris/pull/9926#discussion_r887437219


##########
be/src/olap/rowset/rowset_meta.h:
##########
@@ -276,6 +277,22 @@ class RowsetMeta {
         return _rowset_meta_pb.alpha_rowset_extra_meta_pb();
     }
 
+    void set_tablet_schema(const TabletSchema* tablet_schema) {
+        TabletSchemaPB* ts_pb = _rowset_meta_pb.mutable_tablet_schema();
+        tablet_schema->to_schema_pb(ts_pb);
+        CHECK(_schema == nullptr);
+        _schema = std::make_shared<TabletSchema>(*tablet_schema);
+    }
+
+    void set_tablet_schema(const TabletSchema& tablet_schema) {
+        TabletSchemaPB* ts_pb = _rowset_meta_pb.mutable_tablet_schema();
+        tablet_schema.to_schema_pb(ts_pb);
+        CHECK(_schema == nullptr);
+        _schema = std::make_shared<TabletSchema>(tablet_schema);
+    }

Review Comment:
   Two set_tablet_schema methods here is duplicated? Does either one is enough?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org