[jira] [Commented] (BIGTOP-1047) Support Puppet 3.x

["vishnu gajendran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306219#comment-14306219 ] 

vishnu gajendran commented on BIGTOP-1047:
------------------------------------------

I was checking the patch. I believe there are still places where variables are used assuming dynamic scoping. For example, in https://github.com/apache/bigtop/blob/master/bigtop-deploy/puppet/modules/hadoop/manifests/init.pp file, I see $auth, $ha variables used in common, common-hdfs, common-yarn classes assuming that these variables are available from outer scopes. Please correct me if I am missing something here.

> Support Puppet 3.x
> ------------------
>
>                 Key: BIGTOP-1047
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1047
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: deployment
>    Affects Versions: 0.6.0
>            Reporter: Andrey Klochkov
>            Assignee: Evans Ye
>             Fix For: 0.9.0
>
>         Attachments: 0001-BIGTOP-1047.-Support-Puppet-3.x.patch, BIGTOP-1047--n2.patch, BIGTOP-1047.3.patch, BIGTOP-1047.patch
>
>
> Currently bigtop-deploy/puppet module supports Puppet 2.x only. In particular, this is because of using dynamic scoping which was deprecated since 2.5 and not supported in 3.x. This task is to get rid of dynamic scoping to make bigtop-deploy/puppet working with Puppet 3.x.
> More on dynamic scoping in Puppet: http://docs.puppetlabs.com/guides/scope_and_puppet.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)