You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/11/21 23:13:09 UTC

[GitHub] spark pull request #18784: [SPARK-21559][Mesos] remove mesos fine-grained mo...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18784#discussion_r235563605
  
    --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala ---
    @@ -81,8 +79,8 @@ private[spark] class MesosCoarseGrainedSchedulerBackend(
       private val taskLabels = conf.get("spark.mesos.task.labels", "")
     
       private[this] val shutdownTimeoutMS =
    -    conf.getTimeAsMs("spark.mesos.coarse.shutdownTimeout", "10s")
    -      .ensuring(_ >= 0, "spark.mesos.coarse.shutdownTimeout must be >= 0")
    +    conf.getTimeAsMs("spark.mesos.shutdownTimeout", "10s")
    --- End diff --
    
    Does this property name change need to be reflected in docs? I wasn't sure.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org