You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/05/09 08:33:39 UTC
[GitHub] candyleer opened a new issue #1196: Complex span info for
AsyncHttpClient and exception
candyleer opened a new issue #1196: Complex span info for AsyncHttpClient and exception
URL: https://github.com/apache/incubator-skywalking/issues/1196
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement
___
### Question
- What do you want to know?
___
### Bug
- Which version of SkyWalking, OS and JRE?
master latest
- Which company or project?
- What happen?
#### Improvement
If I send a request with `Async Http Client`,it will generate 5 span info and these make me confused what does these span mean ,maybe end users only concern the main cost for the http request.
below the image show one request that the async http client generate.
![image](https://user-images.githubusercontent.com/11530760/39804131-c59fedba-53a5-11e8-9bf1-6c7d29d4be84.png)
#### Exception
another issue
some times it will throw some exception but not every time and I cannot pinpoint the reason when I read the code
```
ERROR 2018-05-09 15:52:38 InstMethodsInter : class[class org.apache.http.impl.nio.reactor.DefaultConnectingIOReactor] after method[processEvent] intercept failure
java.lang.NullPointerException
at org.apache.skywalking.apm.agent.core.context.ContextManager.activeSpan(ContextManager.java:155)
at org.apache.skywalking.apm.agent.core.context.ContextManager.stopSpan(ContextManager.java:159)
at org.apache.skywalking.apm.plugin.httpasyncclient.v4.DefaultConnectingIOReactorIterceptor.afterMethod(DefaultConnectingIOReactorIterceptor.java:51)
at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:105)
at org.apache.http.impl.nio.reactor.DefaultConnectingIOReactor.processEvent(DefaultConnectingIOReactor.java)
at org.apache.http.impl.nio.reactor.DefaultConnectingIOReactor.processEvents(DefaultConnectingIOReactor.java:145)
at org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor.execute(AbstractMultiworkerIOReactor.java:348)
at org.apache.http.impl.nio.conn.PoolingNHttpClientConnectionManager.execute(PoolingNHttpClientConnectionManager.java:194)
at org.apache.http.impl.nio.client.CloseableHttpAsyncClientBase$1.run(CloseableHttpAsyncClientBase.java:64)
at java.lang.Thread.run(Thread.java:748)
ERROR 2018-05-09 15:52:38 InstMethodsInter : class[class org.apache.http.impl.nio.conn.CPool] before method[requestCompleted] intercept failure
java.lang.IllegalArgumentException: ContextSnapshot can't be null.
at org.apache.skywalking.apm.agent.core.context.ContextManager.continued(ContextManager.java:147)
at org.apache.skywalking.apm.plugin.httpasyncclient.v4.SuccessInterceptor.beforeMethod(SuccessInterceptor.java:46)
at org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstMethodsInter.intercept(InstMethodsInter.java:82)
at org.apache.http.nio.pool.AbstractNIOConnPool.requestCompleted(AbstractNIOConnPool.java)
at org.apache.http.nio.pool.AbstractNIOConnPool$InternalSessionRequestCallback.completed(AbstractNIOConnPool.java:836)
at org.apache.http.impl.nio.reactor.SessionRequestImpl.completed(SessionRequestImpl.java:135)
at org.apache.http.impl.nio.reactor.AbstractIOReactor.processNewChannels(AbstractIOReactor.java:424)
at org.apache.http.impl.nio.reactor.AbstractIOReactor.execute(AbstractIOReactor.java:287)
at org.apache.http.impl.nio.reactor.BaseIOReactor.execute(BaseIOReactor.java:104)
at org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor$Worker.run(AbstractMultiworkerIOReactor.java:588)
at java.lang.Thread.run(Thread.java:748)
```
___
### Requirement or improvement
- Please describe about your requirements or improvement suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services