You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/06 18:08:42 UTC
[kudu-CR] log util: downgrade scary "missing footer" message to INFO
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4319
to review the following change.
Change subject: log_util: downgrade scary "missing footer" message to INFO
......................................................................
log_util: downgrade scary "missing footer" message to INFO
In most cases if a Kudu server restarts, it will leave log segments with
no footer. This previously caused a scary-looking warning to be emitted
on the next startup.
This downgrades the message to INFO for the case of the footer not being
found. I also fixed this code path to properly propagate other types of
errors (eg IOError) which might occur while reading the footer.
Change-Id: Ic60f57e1276e6e4cc209d37d6fdad444c24db3c6
---
M src/kudu/consensus/log_util.cc
1 file changed, 10 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/4319/1
--
To view, visit http://gerrit.cloudera.org:8080/4319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic60f57e1276e6e4cc209d37d6fdad444c24db3c6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] log util: downgrade scary "missing footer" message to INFO
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: log_util: downgrade scary "missing footer" message to INFO
......................................................................
log_util: downgrade scary "missing footer" message to INFO
In most cases if a Kudu server restarts, it will leave log segments with
no footer. This previously caused a scary-looking warning to be emitted
on the next startup.
This downgrades the message to INFO for the case of the footer not being
found. I also fixed this code path to properly propagate other types of
errors (eg IOError) which might occur while reading the footer.
Change-Id: Ic60f57e1276e6e4cc209d37d6fdad444c24db3c6
Reviewed-on: http://gerrit.cloudera.org:8080/4319
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/log_util.cc
1 file changed, 10 insertions(+), 4 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic60f57e1276e6e4cc209d37d6fdad444c24db3c6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] log util: downgrade scary "missing footer" message to INFO
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: log_util: downgrade scary "missing footer" message to INFO
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3234/
--
To view, visit http://gerrit.cloudera.org:8080/4319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic60f57e1276e6e4cc209d37d6fdad444c24db3c6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] log util: downgrade scary "missing footer" message to INFO
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: log_util: downgrade scary "missing footer" message to INFO
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4319
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic60f57e1276e6e4cc209d37d6fdad444c24db3c6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No