You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/15 02:24:11 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #10884: fix(cypress): wait for filterValues request
nytai opened a new pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Seeing a lot of cypress failures for `explore/AdhocFilters` test. 🤞 this makes it less flaky.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
CI passes
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #10884: fix(cypress): wait for filterValues request
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884#issuecomment-692978382
Yup.... also got a random failure for the `dashboard/list_view.test.ts` on https://github.com/apache/incubator-superset/pull/10892/checks?check_run_id=1119843982 seems there's still quite a bit of flakiness in the suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10884: fix(cypress): wait for filterValues request
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884#issuecomment-692974261
@nytai Yeah, it's really strange that it only fails in my fork but it shouldn't really matter if it's not happening for everyone else.
Although I was still seeing `AdhocFilters` failing after rebasing to this fix: https://github.com/apache/incubator-superset/pull/10837/checks?check_run_id=1119508451
So I made another attempt to fix it: https://github.com/apache/incubator-superset/pull/10837/commits/4477fdd5a1ecdbc4eeaa8ceb8575d729bd2960c8
Based on my previous experience, there seems to be some flakiness related to `cy.get(...).within(...)` so I removed the `within` calls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #10884: fix(cypress): wait for filterValues request
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10884: fix(cypress): wait for filterValues request
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884#issuecomment-692481073
<img width="941" alt="Screen Shot 2020-09-14 at 10 51 34 PM" src="https://user-images.githubusercontent.com/487433/93170859-db421300-f6dc-11ea-8d18-8e261bf28ed9.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10884: fix(cypress): wait for filterValues request
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884#issuecomment-692878335
Big thanks @nytai, I was wondering why my one-liner doc PR was failing miserably on CI 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10884: fix(cypress): wait for filterValues request
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884#issuecomment-692480900
I'm seeing codecov download/uplaod step in cypress trigger :/ Let's get CI back on track!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #10884: fix(cypress): wait for filterValues request
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884#issuecomment-692846441
@ktmud Most of the cypress ci failures I've been seeing have been in `AdhocFilters` test. Have you noticed flakiness in the dashboard CRUD views tests in this repo? Seems quite strange that it would be happening in your fork but not in this repo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #10884: fix(cypress): wait for filterValues request
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884#issuecomment-692974261
@nytai Yeah, it's really strange that it only fails in my fork but it shouldn't really matter if it's not happening for everyone else.
Although I was still seeing `AdhocFilters` failing after rebasing to this fix: https://github.com/apache/incubator-superset/pull/10837/checks?check_run_id=1119508451
So I made another attempt to fix it: https://github.com/apache/incubator-superset/pull/10837/commits/4477fdd5a1ecdbc4eeaa8ceb8575d729bd2960c8
Based on my previous experience, there seems to be some flakiness related to `cy.get(...).within(...)` so I removed the `within` calls. I remember reading somewhere in Cypress it's always better to re-select the element other than relying on `within` but I couldn't find the link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org