You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/28 15:25:50 UTC

[GitHub] [apisix-dashboard] starsz opened a new pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test

starsz opened a new pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#issuecomment-751750543


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=h1) Report
   > Merging [#1139](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=desc) (e836046) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/f009244f06f4936be1c94d0c2745343577a245b8?el=desc) (f009244) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1139/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1139   +/-   ##
   =======================================
     Coverage   42.30%   42.30%           
   =======================================
     Files          31       31           
     Lines        1924     1924           
   =======================================
     Hits          814      814           
     Misses       1000     1000           
     Partials      110      110           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=footer). Last update [f009244...e836046](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#discussion_r549583948



##########
File path: api/test/e2e/global_rule_test.go
##########
@@ -79,7 +80,7 @@ func TestGlobalRule(t *testing.T) {
 			ExpectStatus:  http.StatusOK,
 			ExpectBody:    "hello world",
 			ExpectHeaders: map[string]string{"X-VERSION": "1.0"},
-			Sleep:         sleepTime,
+			Sleep:         longSleepTime,

Review comment:
       OK. I had added the comment at base.go already.
   
   https://github.com/starsz/apisix-dashboard/blob/e836046319fe37920f0d65c5a48d19aaa96b7d54/api/test/e2e/base.go#L185-L186




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io commented on pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#issuecomment-751750543


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=h1) Report
   > Merging [#1139](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=desc) (c3b5566) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/822aa6d1f40c5eb5bfef00030304eb5b619a9eea?el=desc) (822aa6d) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1139/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1139   +/-   ##
   =======================================
     Coverage   42.30%   42.30%           
   =======================================
     Files          31       31           
     Lines        1924     1924           
   =======================================
     Hits          814      814           
     Misses       1000     1000           
     Partials      110      110           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=footer). Last update [822aa6d...c3b5566](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#discussion_r549582736



##########
File path: api/test/docker/apisix_config.yaml
##########
@@ -42,6 +42,7 @@ apisix:
 
 nginx_config:
   error_log_level: "debug"
+  worker_processes: "1"

Review comment:
       need a comment, only for debug now

##########
File path: api/test/e2e/global_rule_test.go
##########
@@ -79,7 +80,7 @@ func TestGlobalRule(t *testing.T) {
 			ExpectStatus:  http.StatusOK,
 			ExpectBody:    "hello world",
 			ExpectHeaders: map[string]string{"X-VERSION": "1.0"},
-			Sleep:         sleepTime,
+			Sleep:         longSleepTime,

Review comment:
       And please update other similar points

##########
File path: api/test/e2e/global_rule_test.go
##########
@@ -79,7 +80,7 @@ func TestGlobalRule(t *testing.T) {
 			ExpectStatus:  http.StatusOK,
 			ExpectBody:    "hello world",
 			ExpectHeaders: map[string]string{"X-VERSION": "1.0"},
-			Sleep:         sleepTime,
+			Sleep:         longSleepTime,

Review comment:
       need some comment too. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#issuecomment-751979037


   @starsz CI failed again. please take a look


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1139: fix: minish resync_delay for e2e test

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#issuecomment-751750543


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=h1) Report
   > Merging [#1139](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=desc) (4149ef7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8f94c844218913fdf9e36cd7c62bbe94188ffed3?el=desc) (8f94c84) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1139/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1139   +/-   ##
   =======================================
     Coverage   42.30%   42.30%           
   =======================================
     Files          31       31           
     Lines        1924     1924           
   =======================================
     Hits          814      814           
     Misses       1000     1000           
     Partials      110      110           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=footer). Last update [8f94c84...4149ef7](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#discussion_r549584619



##########
File path: api/test/docker/apisix_config.yaml
##########
@@ -42,6 +42,7 @@ apisix:
 
 nginx_config:
   error_log_level: "debug"
+  worker_processes: "1"

Review comment:
       Only for debug? Maybe I will add it to master if it can make the e2e test passed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#issuecomment-751750543


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=h1) Report
   > Merging [#1139](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=desc) (58adf70) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/822aa6d1f40c5eb5bfef00030304eb5b619a9eea?el=desc) (822aa6d) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1139/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1139      +/-   ##
   ==========================================
   - Coverage   42.30%   42.25%   -0.06%     
   ==========================================
     Files          31       31              
     Lines        1924     1924              
   ==========================================
   - Hits          814      813       -1     
   - Misses       1000     1001       +1     
     Partials      110      110              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1139/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.37% <0.00%> (-0.63%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=footer). Last update [822aa6d...58adf70](https://codecov.io/gh/apache/apisix-dashboard/pull/1139?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1139: fix: sleep more time for apisix to sync data from etcd in e2e test

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#discussion_r549591037



##########
File path: api/test/docker/apisix_config.yaml
##########
@@ -42,6 +42,7 @@ apisix:
 
 nginx_config:
   error_log_level: "debug"
+  worker_processes: "1"

Review comment:
       we need to find the real bug. 
   
   I think we should remove this field in E2E case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on pull request #1139: fix: minish resync_delay for e2e test

Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139#issuecomment-752004228


   Hi, @membphis @nic-chen  Please have a look. I found the cause of the problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] nic-chen merged pull request #1139: fix: minish resync_delay for e2e test

Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #1139:
URL: https://github.com/apache/apisix-dashboard/pull/1139


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org