[GitHub] [drill] vvysotskyi commented on a change in pull request #1919: DRILL-7471: DESCRIBE TABLE command fails with ClassCastException when Metastore is enabled

[GitBox <gi...@apache.org>]

vvysotskyi commented on a change in pull request #1919: DRILL-7471: DESCRIBE TABLE command fails with ClassCastException when Metastore is enabled
URL: https://github.com/apache/drill/pull/1919#discussion_r355128236
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/Records.java
 ##########
 @@ -750,10 +751,8 @@ public Partition(String catalog, String schemaName, String value, PartitionMetad
       this.LAST_MODIFIED_TIME = convertToTimestamp(partitionMetadata.getLastModifiedTime());
     }
 
-    public static List<Partition> fromSegment(String catalog, String schemaName, SegmentMetadata segmentMetadata) {
-      return segmentMetadata.getPartitionValues().stream()
-        .map(value -> new Partition(catalog, schemaName, value, segmentMetadata))
-        .collect(Collectors.toList());
+    public static Partition fromSegment(String catalog, String schemaName, SegmentMetadata segmentMetadata) {
 
 Review comment:
   You are right, changed the approach to populate segment partition values correctly. Thanks a lot for pointing this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services