You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/30 07:35:05 UTC
[GitHub] [rocketmq-clients] CherishCai opened a new pull request, #335: Doc: Rust README.md and Cargo.toml
CherishCai opened a new pull request, #335:
URL: https://github.com/apache/rocketmq-clients/pull/335
- remove main.rs
- add README.md
- add features in Cargo.toml, upgrade `tonic` and `prost`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by "CherishCai (via GitHub)" <gi...@apache.org>.
CherishCai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1121817089
##########
rust/src/lib.rs:
##########
@@ -14,13 +14,17 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-#[path = "pb/apache.rocketmq.v2.rs"]
Review Comment:
It should be the upgrade of tonic=0.8, and then the CI did that because of the error. Now it has been rolled back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by "CherishCai (via GitHub)" <gi...@apache.org>.
CherishCai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1121071536
##########
rust/README.md:
##########
@@ -0,0 +1,43 @@
+# The Rust Implementation of Apache RocketMQ Client
+
+Here is the rust implementation of the client for [Apache RocketMQ](https://rocketmq.apache.org/).
+It is still at a very early stage of development.
+
+## Prerequisites
+
+| Stage | Requirements |
+| ------- |--------------|
+| Build | Rust 1.66+ |
Review Comment:
> We should use the edition here as we do not have a specific requirement of the rust version.
emmm. How should it be modified? can you give some advice?
Is there a DingTalk group? Some of our friends can participate in the research and development, and it can also be used as a hands-on practice of Rust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by GitBox <gi...@apache.org>.
CherishCai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1059649409
##########
rust/README.md:
##########
@@ -0,0 +1,43 @@
+# The Rust Implementation of Apache RocketMQ Client
+
+Here is the rust implementation of the client for [Apache RocketMQ](https://rocketmq.apache.org/).
+It is still at a very early stage of development.
+
+## Prerequisites
+
+| Stage | Requirements |
+| ------- |--------------|
+| Build | Rust 1.66+ |
Review Comment:
The new version of the grammar candy is very good, and there is not much use of advanced features. At that time, if there is a demand for expanding the scope of use, simple modifications should be available.
As far as I know, Rust is simple and common. In fact, it is not long ago that many library support 1.49+ 1.56+.
So it's not a big problem. Improve it first and then consider the version support according to the user's issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by GitBox <gi...@apache.org>.
CherishCai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1059651597
##########
rust/README.md:
##########
@@ -0,0 +1,43 @@
+# The Rust Implementation of Apache RocketMQ Client
+
+Here is the rust implementation of the client for [Apache RocketMQ](https://rocketmq.apache.org/).
+It is still at a very early stage of development.
+
+## Prerequisites
+
+| Stage | Requirements |
+| ------- |--------------|
+| Build | Rust 1.66+ |
Review Comment:
@aaron-ai I am also not a rust expert.
Not long ago, I contributed `nacos-sdk-rust` to get started. It should be OK for users to use it. It is easy to upgrade the new version of Rust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] lizhanhui commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1121065810
##########
rust/README.md:
##########
@@ -0,0 +1,43 @@
+# The Rust Implementation of Apache RocketMQ Client
+
+Here is the rust implementation of the client for [Apache RocketMQ](https://rocketmq.apache.org/).
+It is still at a very early stage of development.
+
+## Prerequisites
+
+| Stage | Requirements |
+| ------- |--------------|
+| Build | Rust 1.66+ |
Review Comment:
@CherishCai We should use the edition here as we do not have a specific requirement of the rust version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1059646376
##########
rust/README.md:
##########
@@ -0,0 +1,43 @@
+# The Rust Implementation of Apache RocketMQ Client
+
+Here is the rust implementation of the client for [Apache RocketMQ](https://rocketmq.apache.org/).
+It is still at a very early stage of development.
+
+## Prerequisites
+
+| Stage | Requirements |
+| ------- |--------------|
+| Build | Rust 1.66+ |
Review Comment:
@CherishCai Generally, the minimal version we support is largely consistent with the version that gRPC supports.
I am not a rust expert. Is it possible that some developers think we only support 1.66+ from the readme? If so, the compatibility of the RocketMQ rust client may be difficult to keep after a library that requires 1.66+ is introduced by someone and widely used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai closed pull request #335: Doc: Rust README.md and Cargo.toml
Posted by "CherishCai (via GitHub)" <gi...@apache.org>.
CherishCai closed pull request #335: Doc: Rust README.md and Cargo.toml
URL: https://github.com/apache/rocketmq-clients/pull/335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai commented on pull request #335: Doc: Rust README.md and Cargo.toml
Posted by GitBox <gi...@apache.org>.
CherishCai commented on PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#issuecomment-1367808079
如果要用新版 tonic 和 prost ，估计还是 test build proto 更佳了，先回滚。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] github-actions[bot] commented on pull request #335: Doc: Rust README.md and Cargo.toml
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#issuecomment-1492753895
This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by GitBox <gi...@apache.org>.
CherishCai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1059643582
##########
rust/README.md:
##########
@@ -0,0 +1,43 @@
+# The Rust Implementation of Apache RocketMQ Client
+
+Here is the rust implementation of the client for [Apache RocketMQ](https://rocketmq.apache.org/).
+It is still at a very early stage of development.
+
+## Prerequisites
+
+| Stage | Requirements |
+| ------- |--------------|
+| Build | Rust 1.66+ |
Review Comment:
It simply defines the latest stable version at the current.
Of course, the previous version can be supported, but since we will gradually improve it from now on, let's use the latest version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by "CherishCai (via GitHub)" <gi...@apache.org>.
CherishCai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1121817984
##########
rust/README.md:
##########
@@ -0,0 +1,43 @@
+# The Rust Implementation of Apache RocketMQ Client
+
+Here is the rust implementation of the client for [Apache RocketMQ](https://rocketmq.apache.org/).
+It is still at a very early stage of development.
+
+## Prerequisites
+
+| Stage | Requirements |
+| ------- |--------------|
+| Build | Rust 1.66+ |
Review Comment:
delete Prerequisites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by "CherishCai (via GitHub)" <gi...@apache.org>.
CherishCai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1121074274
##########
rust/src/lib.rs:
##########
@@ -14,13 +14,17 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-#[path = "pb/apache.rocketmq.v2.rs"]
Review Comment:
> @CherishCai Why include! over specifying path? rust-analyzer works better, say jump to definition if specifying mod by path.
I'll try again when I go back tonight, it's been a while since I wrote it. Maybe it was changed because of some compilation problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] lizhanhui commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by "lizhanhui (via GitHub)" <gi...@apache.org>.
lizhanhui commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1121072380
##########
rust/src/lib.rs:
##########
@@ -14,13 +14,17 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-#[path = "pb/apache.rocketmq.v2.rs"]
Review Comment:
@CherishCai Why include! over specifying path?
rust-analyzer works better, say jump to definition if specifying mod by path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1059642993
##########
rust/README.md:
##########
@@ -0,0 +1,43 @@
+# The Rust Implementation of Apache RocketMQ Client
+
+Here is the rust implementation of the client for [Apache RocketMQ](https://rocketmq.apache.org/).
+It is still at a very early stage of development.
+
+## Prerequisites
+
+| Stage | Requirements |
+| ------- |--------------|
+| Build | Rust 1.66+ |
Review Comment:
Could you clarify why we support this version rather than the previous one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] CherishCai commented on a diff in pull request #335: Doc: Rust README.md and Cargo.toml
Posted by GitBox <gi...@apache.org>.
CherishCai commented on code in PR #335:
URL: https://github.com/apache/rocketmq-clients/pull/335#discussion_r1062131336
##########
rust/README.md:
##########
@@ -0,0 +1,43 @@
+# The Rust Implementation of Apache RocketMQ Client
+
+Here is the rust implementation of the client for [Apache RocketMQ](https://rocketmq.apache.org/).
+It is still at a very early stage of development.
+
+## Prerequisites
+
+| Stage | Requirements |
+| ------- |--------------|
+| Build | Rust 1.66+ |
Review Comment:
@aaron-ai What changes need to be made? If possible, I will refer to Java to define the following apis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org