[GitHub] [hbase] Apache9 commented on pull request #3478: HBASE-26081 Copy HBTU to hbase-testing-util, rename the HBTU related …

[GitBox <gi...@apache.org>]

Apache9 commented on pull request #3478:
URL: https://github.com/apache/hbase/pull/3478#issuecomment-879004187


   This is a very big change.
   
   The classes in the new package, org.apache.hadoop.hbase.testing, are all the classes we want to hide from end users, including HBTU and its parent classes, and HBaseCluster and MiniHBaseCluster. All these classes are changed to IA.LimitedPrivate(Phoenix), as I believe Phoenix still needs test some internal stuff of HBase. The DistributedHBaseCluster is kept as is since it is IA.Private.
   
   And then I copied the classes under the new org.apache.hadoop.hbase.testing to org.apache.hadoop.hbase in hbase-testing-module, still keep the IA.Public annotation but mark them all as deprecated, which will be removed in 4.0.0, for keeping compatible. Also modified the HBTU a bit to remove the dependency on junit, by throwing AssertionError directly, as I do not think we should pull in junit as a compile dependency for any libraries...
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org