You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Lars Kotthoff (JIRA)" <ji...@apache.org> on 2008/03/27 05:13:24 UTC

[jira] Created: (SOLR-513) Links to core admin pages are broken in default admin page

Links to core admin pages are broken in default admin page
----------------------------------------------------------

                 Key: SOLR-513
                 URL: https://issues.apache.org/jira/browse/SOLR-513
             Project: Solr
          Issue Type: Bug
          Components: web gui
    Affects Versions: 1.3
            Reporter: Lars Kotthoff
            Priority: Trivial


The index.jsp page builds the link to the admin pages for cores in a multicore configuration by appending the name of the core to ../../. This works on the admin pages for individual cores, but not on the default admin page -- http://localhost:8080/solr/admin/. The links point to http://localhost:8080/core0/admin etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SOLR-513) Links to core admin pages are broken in default admin page

Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik Hatcher reassigned SOLR-513:
---------------------------------

    Assignee: Erik Hatcher

> Links to core admin pages are broken in default admin page
> ----------------------------------------------------------
>
>                 Key: SOLR-513
>                 URL: https://issues.apache.org/jira/browse/SOLR-513
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Assignee: Erik Hatcher
>            Priority: Trivial
>         Attachments: solr-admin-links.patch
>
>
> The index.jsp page builds the link to the admin pages for cores in a multicore configuration by appending the name of the core to ../../. This works on the admin pages for individual cores, but not on the default admin page -- http://localhost:8080/solr/admin/. The links point to http://localhost:8080/core0/admin etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-513) Links to core admin pages are broken in default admin page

Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik Hatcher updated SOLR-513:
------------------------------

    Fix Version/s: 1.3

> Links to core admin pages are broken in default admin page
> ----------------------------------------------------------
>
>                 Key: SOLR-513
>                 URL: https://issues.apache.org/jira/browse/SOLR-513
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Assignee: Erik Hatcher
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: solr-admin-links.patch
>
>
> The index.jsp page builds the link to the admin pages for cores in a multicore configuration by appending the name of the core to ../../. This works on the admin pages for individual cores, but not on the default admin page -- http://localhost:8080/solr/admin/. The links point to http://localhost:8080/core0/admin etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-513) Links to core admin pages are broken in default admin page

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582538#action_12582538 ] 

Lars Kotthoff commented on SOLR-513:
------------------------------------

Yes, that's exactly the problem. I didn't see any obvious/nice way to check whether the "main" screen is generated though. Maybe appending pathPrefix to the context path would be a general solution?

> Links to core admin pages are broken in default admin page
> ----------------------------------------------------------
>
>                 Key: SOLR-513
>                 URL: https://issues.apache.org/jira/browse/SOLR-513
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Priority: Trivial
>         Attachments: solr-admin-links.patch
>
>
> The index.jsp page builds the link to the admin pages for cores in a multicore configuration by appending the name of the core to ../../. This works on the admin pages for individual cores, but not on the default admin page -- http://localhost:8080/solr/admin/. The links point to http://localhost:8080/core0/admin etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-513) Links to core admin pages are broken in default admin page

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff resolved SOLR-513.
--------------------------------

    Resolution: Fixed

This issue is resolved with the latest changes in SOLR-545 since it's not possible to call an admin page without explicitely specifying a core anymore.

> Links to core admin pages are broken in default admin page
> ----------------------------------------------------------
>
>                 Key: SOLR-513
>                 URL: https://issues.apache.org/jira/browse/SOLR-513
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Assignee: Erik Hatcher
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: SOLR-513.patch, solr-admin-links.patch
>
>
> The index.jsp page builds the link to the admin pages for cores in a multicore configuration by appending the name of the core to ../../. This works on the admin pages for individual cores, but not on the default admin page -- http://localhost:8080/solr/admin/. The links point to http://localhost:8080/core0/admin etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-513) Links to core admin pages are broken in default admin page

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582534#action_12582534 ] 

Hoss Man commented on SOLR-513:
-------------------------------

minor note: i don't think building off of the context path will work if pathPrefix has been configured for the DispatchFilter (in cases where people are embedding all of Solr's stuff into a larger webapp)

assuming i understand the problem: it should probably just check to see if it's generating the "main" admin screen and if so leave out a set of "../"

> Links to core admin pages are broken in default admin page
> ----------------------------------------------------------
>
>                 Key: SOLR-513
>                 URL: https://issues.apache.org/jira/browse/SOLR-513
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Priority: Trivial
>         Attachments: solr-admin-links.patch
>
>
> The index.jsp page builds the link to the admin pages for cores in a multicore configuration by appending the name of the core to ../../. This works on the admin pages for individual cores, but not on the default admin page -- http://localhost:8080/solr/admin/. The links point to http://localhost:8080/core0/admin etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-513) Links to core admin pages are broken in default admin page

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff updated SOLR-513:
-------------------------------

    Attachment: solr-admin-links.patch

Patch to build the link by appending to the root of the servlet context instead of a relative path. Verified to work in Tomcat 5.5. Patch as produced by "svn diff".

> Links to core admin pages are broken in default admin page
> ----------------------------------------------------------
>
>                 Key: SOLR-513
>                 URL: https://issues.apache.org/jira/browse/SOLR-513
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Priority: Trivial
>         Attachments: solr-admin-links.patch
>
>
> The index.jsp page builds the link to the admin pages for cores in a multicore configuration by appending the name of the core to ../../. This works on the admin pages for individual cores, but not on the default admin page -- http://localhost:8080/solr/admin/. The links point to http://localhost:8080/core0/admin etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-513) Links to core admin pages are broken in default admin page

Posted by "Lars Kotthoff (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff updated SOLR-513:
-------------------------------

    Attachment: SOLR-513.patch

I've had a look at this again. As far as I can see, there's no way to get the pathPrefix in the jsp without jumping through some major hoops. Therefore I've decided to try a different approach.

Instead of changing the links in index.jsp I've changed the included _info.jsp to redirect requests to /solr/admin/ to /solr/coreName/admin/. This also makes it explicit which core is used.

I personally think that the default behaviour of randomly picking a core when none is specified in a multicore configuration should be changed to showing an error message or specifying a default core in the multicore configuration. I don't think that the current behaviour should be supported in the future as you can't be sure which core will be selected and it's therefore a potential source of errors. Also it's using a deprecated method to get a core.

Attaching patch which makes the necessary changes to _info.jsp. Tested with multicore configuration on Tomcat and single core configuration on Jetty.

> Links to core admin pages are broken in default admin page
> ----------------------------------------------------------
>
>                 Key: SOLR-513
>                 URL: https://issues.apache.org/jira/browse/SOLR-513
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Assignee: Erik Hatcher
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: SOLR-513.patch, solr-admin-links.patch
>
>
> The index.jsp page builds the link to the admin pages for cores in a multicore configuration by appending the name of the core to ../../. This works on the admin pages for individual cores, but not on the default admin page -- http://localhost:8080/solr/admin/. The links point to http://localhost:8080/core0/admin etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.