You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/10/10 21:47:46 UTC

[GitHub] [beam] phoerious commented on a diff in pull request #16658: [BEAM-12792] Install pipline dependencies to temporary venv

phoerious commented on code in PR #16658:
URL: https://github.com/apache/beam/pull/16658#discussion_r991660368


##########
sdks/python/container/boot.go:
##########
@@ -73,13 +74,20 @@ const (
 )
 
 func main() {
+	if err := mainError(); err != nil {
+		log.Print(err)
+		os.Exit(1)

Review Comment:
   I answered this somewhere above. log.Fatal prevents clean-up of resources, so we cannot shut down the Python worker process cleanly. Without this change, you will end up producing a lot of un-wait()-ed zombie processes and potentially leave temporary files in place etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org