You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "gstvg (via GitHub)" <gi...@apache.org> on 2025/02/09 19:49:10 UTC

[PR] Minor: Fix ArrayDataBuilder::build_unchecked docs [arrow-rs]

gstvg opened a new pull request, #7103:
URL: https://github.com/apache/arrow-rs/pull/7103

   # Which issue does this PR close?
   
   # Rationale for this change
   
   # What changes are included in this PR?
   
   # Are there any user-facing changes?
   
   Docs only
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor: Fix ArrayDataBuilder::build_unchecked docs [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7103:
URL: https://github.com/apache/arrow-rs/pull/7103#discussion_r1948901401


##########
arrow-data/src/data.rs:
##########
@@ -1929,7 +1929,7 @@ impl ArrayDataBuilder {
 
     /// Creates an array data, without any validation
     ///
-    /// Note: This is shorthand for `self.with_skip_validation(true).build()`
+    /// Note: This is shorthand for `self.skip_validation(true).build().unwrap()`

Review Comment:
   That would be great! Perhaps as a follow on PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor: Fix ArrayDataBuilder::build_unchecked docs [arrow-rs]

Posted by "gstvg (via GitHub)" <gi...@apache.org>.
gstvg commented on code in PR #7103:
URL: https://github.com/apache/arrow-rs/pull/7103#discussion_r1957208019


##########
arrow-data/src/data.rs:
##########
@@ -1929,7 +1929,7 @@ impl ArrayDataBuilder {
 
     /// Creates an array data, without any validation
     ///
-    /// Note: This is shorthand for `self.with_skip_validation(true).build()`
+    /// Note: This is shorthand for `self.skip_validation(true).build().unwrap()`

Review Comment:
   I opened #7139 to make it a doctest



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor: Fix ArrayDataBuilder::build_unchecked docs [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7103:
URL: https://github.com/apache/arrow-rs/pull/7103#discussion_r1949845190


##########
arrow-data/src/data.rs:
##########
@@ -1929,7 +1929,7 @@ impl ArrayDataBuilder {
 
     /// Creates an array data, without any validation
     ///
-    /// Note: This is shorthand for `self.with_skip_validation(true).build()`
+    /// Note: This is shorthand for `self.skip_validation(true).build().unwrap()`

Review Comment:
   @gstvg any chance you have some time to make a PR with a doc example?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor: Fix ArrayDataBuilder::build_unchecked docs [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7103:
URL: https://github.com/apache/arrow-rs/pull/7103


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor: Fix ArrayDataBuilder::build_unchecked docs [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on code in PR #7103:
URL: https://github.com/apache/arrow-rs/pull/7103#discussion_r1948665705


##########
arrow-data/src/data.rs:
##########
@@ -1929,7 +1929,7 @@ impl ArrayDataBuilder {
 
     /// Creates an array data, without any validation
     ///
-    /// Note: This is shorthand for `self.with_skip_validation(true).build()`
+    /// Note: This is shorthand for `self.skip_validation(true).build().unwrap()`

Review Comment:
   Thoughts on making it a doctest so we catch it via tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org