[GitHub] [airflow] uranusjr commented on a diff in pull request #29433: Add dataset update endpoint

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #29433:
URL: https://github.com/apache/airflow/pull/29433#discussion_r1117899923


##########
airflow/models/dataset.py:
##########
@@ -275,6 +275,8 @@ class DatasetEvent(Base):
     source_dag_id = Column(StringID(), nullable=True)
     source_run_id = Column(StringID(), nullable=True)
     source_map_index = Column(Integer, nullable=True, server_default=text("-1"))
+    external_service_id = Column(StringID(), nullable=True)
+    external_source = Column(StringID(), nullable=True)

Review Comment:
   How are these different and why can they not be combined into one field?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org