[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #258: Control metadata compression via table properties

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #258: Control metadata compression via table properties
URL: https://github.com/apache/incubator-iceberg/pull/258#discussion_r300802335
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/TableProperties.java
 ##########
 @@ -85,4 +85,7 @@ private TableProperties() {}
 
   public static final String MANIFEST_LISTS_ENABLED = "write.manifest-lists.enabled";
   public static final boolean MANIFEST_LISTS_ENABLED_DEFAULT = true;
+
+  public static final String METADATA_COMPRESSION_ENABLED = "metadata.compression.enabled";
 
 Review comment:
   What about `write.metadata.compression.codec` in case we will have more properties related to compression? Are you proposing to make this a string property instead of boolean?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org