You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "onestarshang (via GitHub)" <gi...@apache.org> on 2023/04/27 04:20:17 UTC
[GitHub] [superset] onestarshang opened a new pull request, #23836: fix(config and clickhouse): Series limit doesn't work in time-series …
onestarshang opened a new pull request, #23836:
URL: https://github.com/apache/superset/pull/23836
…chart on clickhouse engine
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
fix for these issue:
https://github.com/apache/superset/issues/17248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config and clickhouse): the lack of time filter constraints in join subqueries [superset]
Posted by "cwegener (via GitHub)" <gi...@apache.org>.
cwegener commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-2298153183
> I could give it a quick try to see if I can come up with a repro of the actual scenario that exhibits the problem.
I cannot reproduce the issue. the time filter constraints are included in the join sub-query as expected. Maybe someone else has another way of reproducing the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23836: fix(config and clickhouse): the lack of time filter constraints in join subqueries
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-1537739483
@cwegener originally the ClickHouse Connect db engine spec resided in the ClickHouse Connect driver itself. However, it was moved into the Superset repo to make it easier to maintain the spec, as it proved difficult to support multiple versions of Superset due to the BaseEngineSpec constantly evolving over time. As 2.1 is now out and features the ClickHouse Connect engine spec, I suspect the spec will be removed from the ClickHouse connect driver soon. Ping @genzgd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #23836: fix(config and clickhouse): Series limit doesn't work in time-series …
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-1524955647
@onestarshang please provide more context on the need for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config and clickhouse): the lack of time filter constraints in join subqueries [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-2297860182
It's been quite a long time since this PR was touched. Do we still want to get this in? It looks like it needs a rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config and clickhouse): the lack of time filter constraints in join subqueries [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-2815809196
@onestarshang are you still able to reproduce this issue? I'll convert the PR to draft mode for now since it's in need of a rebase, but maybe we don't need it at all? ¯\\\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cwegener commented on pull request #23836: fix(config and clickhouse): the lack of time filter constraints in join subqueries
Posted by "cwegener (via GitHub)" <gi...@apache.org>.
cwegener commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-1537542951
What is the actual authoritative source for the Clickhouse DB Engine Spec? The superset repo or the Clickhouse-connect repo? https://github.com/ClickHouse/clickhouse-connect/blob/09f628b2a31ab5b0ef95914c977c83c4057b0d22/clickhouse_connect/cc_superset/engine.py#L52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yolandazcc commented on a diff in pull request #23836: fix(config and clickhouse): Series limit doesn't work in time-series …
Posted by "yolandazcc (via GitHub)" <gi...@apache.org>.
yolandazcc commented on code in PR #23836:
URL: https://github.com/apache/superset/pull/23836#discussion_r1178691825
##########
superset/db_engine_specs/clickhouse.py:
##########
@@ -46,14 +47,15 @@
if TYPE_CHECKING:
from superset.models.core import Database
+config = app.config
logger = logging.getLogger(__name__)
class ClickHouseBaseEngineSpec(BaseEngineSpec):
"""Shared engine spec for ClickHouse."""
time_secondary_columns = True
- time_groupby_inline = True
+ time_groupby_inline = config['TIME_GROUPBY_INLINE']
Review Comment:
or delete this override line, just use the base model value False?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] onestarshang commented on pull request #23836: fix(config and clickhouse): the lack of time filter constraints in join subqueries
Posted by "onestarshang (via GitHub)" <gi...@apache.org>.
onestarshang commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-1525135663
> @onestarshang please provide more context on the need for this change.
I added some information about this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config and clickhouse): the lack of time filter constraints in join subqueries [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #23836: fix(config and clickhouse): the lack of time filter constraints in join subqueries
URL: https://github.com/apache/superset/pull/23836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config and clickhouse): the lack of time filter constraints in join subqueries [superset]
Posted by "cwegener (via GitHub)" <gi...@apache.org>.
cwegener commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-2298031889
It's a topic that is my domain (ClickHouse with Superset).
I don't have the full context of how to reproduce the issue though, as this seems to have been lost.
I could give it a quick try to see if I can come up with a repro of the actual scenario that exhibits the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yolandazcc commented on pull request #23836: fix(config and clickhouse): the lack of time filter constraints in join subqueries
Posted by "yolandazcc (via GitHub)" <gi...@apache.org>.
yolandazcc commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-1526918264
clickhouse need partition column, the subquery with out time range(usually is partition column) will super slow...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config and clickhouse): the lack of time filter constraints in join subqueries [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23836:
URL: https://github.com/apache/superset/pull/23836#issuecomment-3559567099
Closing due to ongoing inactivity, but we appreciate the contribution and are more than happy to reopen this if you want to pick it back up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org