You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/11 00:59:35 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10376: [Improvement] [Api & Master] Complement function transformation

SbloodyS commented on PR #10376:
URL: https://github.com/apache/dolphinscheduler/pull/10376#issuecomment-1152822213

   > > LGTM overall. But we still have discussion in [#10376 (comment)](https://github.com/apache/dolphinscheduler/pull/10376#discussion_r894520852)
   > 
   > Hi @SbloodyS you should give a approve because the change requested.
   
   Sorry. I don't have strong opinion here. I just not quite sure about whether should give a approve since we still have unresolved discussions.
   
   I gave approved. Do you have better suggestions? @zhongjiajie @caishunfeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org