You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/20 16:18:35 UTC
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile opened a new pull request #803: fix(android): allow compilation in old cordova-android versions
jcesarmobile opened a new pull request #803:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/803
since the plugin don't have engines for cordova-android, people is using it in old cordova-android versions and it fails to compile because it uses some code that is not supported in older SDK compile versions.
This PR should make it compile in older versions (tested only 6.2.3 which targets android-25, could still fail in even older versions)
closes https://github.com/apache/cordova-plugin-inappbrowser/issues/554
after this is merged we should do a patch release and then we can revert and set the engines to cordova-android 9 and remove a lot of code that wouldn't be needed, and then do a major release as updating the engines is a breaking change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile commented on pull request #803: fix(android): allow compilation in old cordova-android versions
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #803:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/803#issuecomment-713135068
Yeah, this is a temporary fix, will revert it once released
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile commented on pull request #803: fix(android): allow compilation in old cordova-android versions
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #803:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/803#issuecomment-713013090
no, it should still work on any capacitor-android version, even on newer ones, it just replaces constants which might not exist with the number they represent
and this other change https://github.com/apache/cordova-plugin-inappbrowser/pull/803/files#diff-b73be6c976a963c35af9c94c6c85447ca3fa5a70f417912f71cce92b16896874L272-L277 just removes `getWebViewClient` usage, which is not available if you compile on cordova-android 6.2.3 (SDK 25) or older, but the code does the same thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] breautek commented on pull request #803: fix(android): allow compilation in old cordova-android versions
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #803:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/803#issuecomment-713002831
I'm assuming this will cause breakage if running on later android targets. We should probably attempt to get this patch and the new major released around the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jcesarmobile merged pull request #803: fix(android): allow compilation in old cordova-android versions
Posted by GitBox <gi...@apache.org>.
jcesarmobile merged pull request #803:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org