You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Attila Szabo <ma...@apache.org> on 2017/02/15 08:28:18 UTC
Re: Review Request 54251: SQOOP-3061 - Fix a bug when parsing query
in sqoop options file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54251/#review165664
-----------------------------------------------------------
Ship it!
Hey Eric,
Although the current solutio for validation is not perfect, but as the test/validation is not missleading anymore, I accept the current solution.
Many thanks for your contribution!
Attila
- Attila Szabo
On Jan. 19, 2017, 12:17 a.m., Eric Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54251/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 12:17 a.m.)
>
>
> Review request for Sqoop and Szabolcs Vasas.
>
>
> Bugs: SQOOP-3061
> https://issues.apache.org/jira/browse/SQOOP-3061
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3061 - Sqoop --options-file failed with error "Malformed option in options file" even though the query is correct
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/util/OptionsFileUtil.java c476e00
> src/test/com/cloudera/sqoop/util/TestOptionsFileExpansion.java 6d3f0f3
>
> Diff: https://reviews.apache.org/r/54251/diff/
>
>
> Testing
> -------
>
> Test case updated and have made sure that existing test cases and new test cases passed.
>
>
> Thanks,
>
> Eric Lin
>
>