You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Giacomo Pati <gi...@apache.org> on 2003/01/08 14:00:28 UTC

Re: cvs commit: xml-cocoon2/src/java/org/apache/cocoon/components/source/impl ContextSourceFactory.java

This change seems to introduce a loop at startup. If I revert to revision
1.6 Cocoon starts as usual.

Sylvain, is this change running on your side? We used Tomcat 4.1.18, JDK
1.3.1, and ./build.sh clean installscratchpadwar.

Giacomo

On 8 Jan 2003 sylvain@apache.org wrote:

> sylvain     2003/01/08 03:04:53
>
>   Modified:    src/java/org/apache/cocoon/components/source/impl
>                         ContextSourceFactory.java
>   Log:
>   Fix bug #15279 (writeable source doesn't work with context: URLs)
>
>   Revision  Changes    Path
>   1.7       +27 -29    xml-cocoon2/src/java/org/apache/cocoon/components/source/impl/ContextSourceFactory.java
>
>   Index: ContextSourceFactory.java
>   ===================================================================


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: cvs commit: xml-cocoon2/src/java/org/apache/cocoon/components/source/impl ContextSourceFactory.java

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Giacomo Pati wrote:

>This change seems to introduce a loop at startup. If I revert to revision
>1.6 Cocoon starts as usual.
>
>Sylvain, is this change running on your side? We used Tomcat 4.1.18, JDK
>1.3.1, and ./build.sh clean installscratchpadwar.
>  
>

Shame on me, I tested only in the 2.0.x branch and not on the 2.1 which 
you seem to use.

I'll check this right away.

Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }



---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: cvs commit: xml-cocoon2/src/java/org/apache/cocoon/components/source/impl ContextSourceFactory.java

Posted by Giacomo Pati <gi...@apache.org>.
On Wed, 8 Jan 2003, Sylvain Wallez wrote:

> Giacomo Pati wrote:
>
> >This change seems to introduce a loop at startup. If I revert to revision
> >1.6 Cocoon starts as usual.
> >
> >Sylvain, is this change running on your side? We used Tomcat 4.1.18, JDK
> >1.3.1, and ./build.sh clean installscratchpadwar.
> >
> >
>
> Fixed.

Thanks. I'll try it right away :)

> For an unknown reason, looking up the SourceResolver in the compose()
> method of a SourceFactory leads to an endless loop. So the fix consists
> in delaying this lookup to the first call to getSource().

Ok.

> I don't know if it's related to Fortress or to the special handling of
> SourceResolver in CocoonComponentManager. Carsten, any idea ?

Fortress? Are we using Fortress in 2.1?

Giacomo


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


RE: cvs commit: xml-cocoon2/src/java/org/apache/cocoon/components/source/impl ContextSourceFactory.java

Posted by Carsten Ziegeler <cz...@s-und-n.de>.

> From: Sylvain Wallez [mailto:sylvain.wallez@anyware-tech.com]
>
>
> Fixed.
>
> For an unknown reason, looking up the SourceResolver in the compose()
> method of a SourceFactory leads to an endless loop. So the fix consists
> in delaying this lookup to the first call to getSource().
>
> I don't know if it's related to Fortress or to the special handling of
> SourceResolver in CocoonComponentManager. Carsten, any idea ?
>
I guess it's a problem of the order in which the components are
instantiated.
The SourceResolver looks up the source factories selector which in turn
looks up the SourceFactory. If then a factory looks up the SourceResolver
you have the loop.
It's nothing you can do anything against right now.

Carsten


---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


Re: cvs commit: xml-cocoon2/src/java/org/apache/cocoon/components/source/impl ContextSourceFactory.java

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Giacomo Pati wrote:

>This change seems to introduce a loop at startup. If I revert to revision
>1.6 Cocoon starts as usual.
>
>Sylvain, is this change running on your side? We used Tomcat 4.1.18, JDK
>1.3.1, and ./build.sh clean installscratchpadwar.
>  
>

Fixed.

For an unknown reason, looking up the SourceResolver in the compose() 
method of a SourceFactory leads to an endless loop. So the fix consists 
in delaying this lookup to the first call to getSource().

I don't know if it's related to Fortress or to the special handling of 
SourceResolver in CocoonComponentManager. Carsten, any idea ?

Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }



---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org