[GitHub] [accumulo] dlmarion commented on a change in pull request #2518: Modified Compression to allow for user-defined algorithms

[GitBox <gi...@apache.org>]

dlmarion commented on a change in pull request #2518:
URL: https://github.com/apache/accumulo/pull/2518#discussion_r813875635



##########
File path: core/pom.xml
##########
@@ -275,6 +275,10 @@
               <excludes />
               <allows>
                 <allow>io[.]opentelemetry[.]api[.]OpenTelemetry</allow>
+                <allow>org[.]apache[.]hadoop[.]conf[.]Configuration</allow>
+                <allow>org[.]apache[.]hadoop[.]io[.]compress[.]CompressionCodec</allow>
+                <allow>org[.]apache[.]hadoop[.]io[.]compress[.]Decompressor</allow>
+                <allow>org[.]apache[.]hadoop[.]io[.]compress[.]Compressor</allow>

Review comment:
       I removed Configuration in c377cb8. I don't really see an easy way to remove the others since the goal of the plugin is to provide a Codec / Compressor / Decompressor. If we internally were not using Hadoop Codecs, then I think this would be much easier to accomplish. Is that what you are suggesting, that we move the internal implementation away from Hadoop Codecs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org