You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Konrad Hosemann (JIRA)" <ji...@apache.org> on 2006/05/16 12:15:17 UTC
[jira] Created: (WW-1313) Result dispatching does not work if event
action is subclass of render action
Result dispatching does not work if event action is subclass of render action
-----------------------------------------------------------------------------
Key: WW-1313
URL: http://issues.apache.org/struts/browse/WW-1313
Project: Struts Action 2
Type: Bug
Components: Portlet Integration
Versions: WW 2.2.2
Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
Reporter: Konrad Hosemann
Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (WW-1313) Result dispatching does not work if event
action is subclass of render action
Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=all ]
Nils-Helge Garli updated WW-1313:
---------------------------------
Attachment: Jsr168Dispatcher.patch
This patch makes sure the top of the stack is preserved when the event action is pushed on the stack.
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: Jsr168Dispatcher.patch, ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (WW-1313) Result dispatching does not work if
event action is subclass of render action
Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=comments#action_37368 ]
Nils-Helge Garli commented on WW-1313:
--------------------------------------
It appears to me that the render action is in fact executed, but since the event action is pushed on the top of the stack, the ${msg} expression tries to evaluate the msg attribute on the event action instead of the render action which is currently executed. And for the event action, this attribute is "null", which probably causes the error.
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (WW-1313) Result dispatching does not work if event
action is subclass of render action
Posted by "Konrad Hosemann (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=all ]
Konrad Hosemann updated WW-1313:
--------------------------------
Attachment: ww-bug.war
ww-bug.psml
war file demonstrating the bug and psml portal page containing the demo-app for use in jetspeed2
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (WW-1313) Result dispatching does not work if
event action is subclass of render action
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=all ]
Don Brown resolved WW-1313:
---------------------------
Fix Version: 2.0.0
Resolution: Fixed
Assign To: Don Brown
Patch applied, thanks Nils
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Assignee: Don Brown
> Fix For: 2.0.0
> Attachments: Jsr168Dispatcher.patch, ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (WW-1313) Result dispatching does not work if
event action is subclass of render action
Posted by "Konrad Hosemann (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=comments#action_37366 ]
Konrad Hosemann commented on WW-1313:
-------------------------------------
This is what I did:
* copy the war to $CATALINA_HOME/webapps/jetspeed/WEB-INF/deploy
* copy the psml to $CATALINA_HOME/webapps/jetspeed/WEB-INF/pages
* go to http://localhost:8080/jetspeed/portal/ww-bug.psml
* click the 'action'-link
* get a freemarker template error because the needed property at the render action was not set because execute() has not been called on that action
* in ActionAction change 'extends RenderAction' to 'extends ActionSupport', compile, deploy
* everything works fine now
I will also check if I can get this to work in pluto
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (WW-1313) Result dispatching does not work if event
action is subclass of render action
Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=all ]
Nils-Helge Garli updated WW-1313:
---------------------------------
Attachment: Jsr168Dispatcher.patch
This patch makes sure the top of the stack is preserved when the event action is pushed on the stack.
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: Jsr168Dispatcher.patch, ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (WW-1313) Result dispatching does not work if
event action is subclass of render action
Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=comments#action_37365 ]
Nils-Helge Garli commented on WW-1313:
--------------------------------------
I can't seem to reproduce this. Have you launched Tomcat in debug mode and stepped through to see that it is not executed as expected? Have you tested in pluto? Do you have more information that can help reproduce this issue?
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (WW-1313) Result dispatching does not work if
event action is subclass of render action
Posted by "Konrad Hosemann (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=comments#action_37372 ]
Konrad Hosemann commented on WW-1313:
-------------------------------------
Thanks for the patch, it solves the problem and everything seems to work well. We will use it from now on for our development
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: Jsr168Dispatcher.patch, ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (WW-1313) Result dispatching does not work if
event action is subclass of render action
Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=comments#action_37365 ]
Nils-Helge Garli commented on WW-1313:
--------------------------------------
I can't seem to reproduce this. Have you launched Tomcat in debug mode and stepped through to see that it is not executed as expected? Have you tested in pluto? Do you have more information that can help reproduce this issue?
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (WW-1313) Result dispatching does not work if
event action is subclass of render action
Posted by "Konrad Hosemann (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=comments#action_37366 ]
Konrad Hosemann commented on WW-1313:
-------------------------------------
This is what I did:
* copy the war to $CATALINA_HOME/webapps/jetspeed/WEB-INF/deploy
* copy the psml to $CATALINA_HOME/webapps/jetspeed/WEB-INF/pages
* go to http://localhost:8080/jetspeed/portal/ww-bug.psml
* click the 'action'-link
* get a freemarker template error because the needed property at the render action was not set because execute() has not been called on that action
* in ActionAction change 'extends RenderAction' to 'extends ActionSupport', compile, deploy
* everything works fine now
I will also check if I can get this to work in pluto
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (WW-1313) Result dispatching does not work if
event action is subclass of render action
Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=comments#action_37368 ]
Nils-Helge Garli commented on WW-1313:
--------------------------------------
It appears to me that the render action is in fact executed, but since the event action is pushed on the top of the stack, the ${msg} expression tries to evaluate the msg attribute on the event action instead of the render action which is currently executed. And for the event action, this attribute is "null", which probably causes the error.
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (WW-1313) Result dispatching does not work if
event action is subclass of render action
Posted by "Konrad Hosemann (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=comments#action_37372 ]
Konrad Hosemann commented on WW-1313:
-------------------------------------
Thanks for the patch, it solves the problem and everything seems to work well. We will use it from now on for our development
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: Jsr168Dispatcher.patch, ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (WW-1313) Result dispatching does not work if event
action is subclass of render action
Posted by "Konrad Hosemann (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/WW-1313?page=all ]
Konrad Hosemann updated WW-1313:
--------------------------------
Attachment: ww-bug.war
ww-bug.psml
war file demonstrating the bug and psml portal page containing the demo-app for use in jetspeed2
> Result dispatching does not work if event action is subclass of render action
> -----------------------------------------------------------------------------
>
> Key: WW-1313
> URL: http://issues.apache.org/struts/browse/WW-1313
> Project: Struts Action 2
> Type: Bug
> Components: Portlet Integration
> Versions: WW 2.2.2
> Environment: Jetspeed 2.0.1, Tomcat 5.5.15, Java 1.5
> Reporter: Konrad Hosemann
> Attachments: ww-bug.psml, ww-bug.war
>
> Portlet result dispatching as described in the second bullet http://wiki.opensymphony.com/display/WW/Portlet+Configuration does not work if the action executed in the event phase is a subclass of the action that should be executed in the following render phase. In this case the render action will not be executed.
> Please see the attached ready-to-run war file, it also contains the sources
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira