[GitHub] [hadoop-ozone] dineshchitlangia commented on a change in pull request #154: HDDS-2469. Avoid changing client-side key metadata

[GitBox <gi...@apache.org>]

dineshchitlangia commented on a change in pull request #154: HDDS-2469. Avoid changing client-side key metadata
URL: https://github.com/apache/hadoop-ozone/pull/154#discussion_r346056363
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
 ##########
 @@ -693,10 +694,13 @@ public void testPutKey()
 
     for (int i = 0; i < 10; i++) {
       String keyName = UUID.randomUUID().toString();
+      Map<String, String> metadata = new HashMap<>(1);
+      metadata.put(OzoneConsts.GDPR_FLAG, Boolean.toString(i % 2 == 0));
+      Map<String, String> originalMetadata = ImmutableMap.copyOf(metadata);
 
       OzoneOutputStream out = bucket.createKey(keyName,
           value.getBytes().length, STAND_ALONE,
-          ONE, new HashMap<>());
+          ONE, metadata);
 
 Review comment:
   Since this test is called PutKey, it is for generic putkey. To test the GDPR feature, we have dedicated tests in the same class. 
   I recommend undoing this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org