You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/03/08 05:23:50 UTC
[GitHub] [carbondata] kunal642 commented on a change in pull request #4099: [CARBONDATA-4141] Index Server is not caching indexes for external tables with sdk segments.
kunal642 commented on a change in pull request #4099:
URL: https://github.com/apache/carbondata/pull/4099#discussion_r589176617
##########
File path: core/src/main/java/org/apache/carbondata/core/index/IndexUtil.java
##########
@@ -112,15 +116,31 @@ public static IndexJob getIndexJob(Configuration configuration) throws IOExcepti
*/
private static void executeClearIndexJob(IndexJob indexJob,
CarbonTable carbonTable, String indexToClear) throws IOException {
- SegmentStatusManager.ValidAndInvalidSegmentsInfo validAndInvalidSegmentsInfo =
- getValidAndInvalidSegments(carbonTable, FileFactory.getConfiguration());
- List<String> invalidSegment = new ArrayList<>();
- for (Segment segment : validAndInvalidSegmentsInfo.getInvalidSegments()) {
- invalidSegment.add(segment.getSegmentNo());
+ IndexInputFormat indexInputFormat;
+ if (!carbonTable.isTransactionalTable()) {
Review comment:
Please reuse the LatestFilesReadCommittedScope class to take a snapshot of the non-transactional table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org