You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/04 07:32:06 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #12621: Remove corrupt visible testing annotation in function workers
Shoothzj opened a new pull request #12621:
URL: https://github.com/apache/pulsar/pull/12621
### Motivation
Remove corrupt visible testing annotation in function workers, make code reader confusing
### Modifications
- Remove corrupt visible testing annotation
- fix a typo
- rename a unused method since 2017
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `no-need-doc`
simple internal changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #12621: Remove corrupt visible testing annotation in function workers
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12621:
URL: https://github.com/apache/pulsar/pull/12621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12621: Remove corrupt visible testing annotation in function workers
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12621:
URL: https://github.com/apache/pulsar/pull/12621#issuecomment-960666652
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12621: Remove corrupt visible testing annotation in function workers
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12621:
URL: https://github.com/apache/pulsar/pull/12621#issuecomment-960892619
> Lgtm
>
> What do you mean with 'corrupt'? Do you mean 'wrong ' ?
I mean, After a long time, the method annotated `VisibleTesting` has already been used by src code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #12621: Remove corrupt visible testing annotation in function workers
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12621:
URL: https://github.com/apache/pulsar/pull/12621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12621: Remove corrupt visible testing annotation in function workers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12621:
URL: https://github.com/apache/pulsar/pull/12621#issuecomment-960518064
@Shoothzj:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #12621: Remove corrupt visible testing annotation in function workers
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12621:
URL: https://github.com/apache/pulsar/pull/12621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12621: Remove corrupt visible testing annotation in function workers
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12621:
URL: https://github.com/apache/pulsar/pull/12621#issuecomment-960565142
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #12621: Remove corrupt visible testing annotation in function workers
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #12621:
URL: https://github.com/apache/pulsar/pull/12621#issuecomment-960889745
> Lgtm
>
> What do you mean with 'corrupt'? Do you mean 'wrong ' ?
I mean, After a long time, the method annotated `VisibleTesting` has already been used by src code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org