You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/11/14 18:15:29 UTC
Review Request 63803: Log Feeder: do not try to connect AMS,
when it is disabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63803/
-----------------------------------------------------------
Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
Bugs: AMBARI-22443
https://issues.apache.org/jira/browse/AMBARI-22443
Repository: ambari
Description
-------
Set ams client to null if any of their properties are null.
Its already merged/fixed in 2.6 branch
Diffs
-----
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java f446446
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java 1094852
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetricsManagerTest.java 24042a7
Diff: https://reviews.apache.org/r/63803/diff/1/
Testing
-------
done
Thanks,
Oliver Szabo
Re: Review Request 63803: Log Feeder: do not try to connect AMS,
when it is disabled
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63803/#review190990
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Nov. 14, 2017, 6:15 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63803/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 6:15 p.m.)
>
>
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
>
>
> Bugs: AMBARI-22443
> https://issues.apache.org/jira/browse/AMBARI-22443
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Set ams client to null if any of their properties are null.
>
> Its already merged/fixed in 2.6 branch
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java f446446
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java 1094852
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetricsManagerTest.java 24042a7
>
>
> Diff: https://reviews.apache.org/r/63803/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 63803: Log Feeder: do not try to connect AMS,
when it is disabled
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63803/#review190984
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On Nov. 14, 2017, 6:15 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63803/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 6:15 p.m.)
>
>
> Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
>
>
> Bugs: AMBARI-22443
> https://issues.apache.org/jira/browse/AMBARI-22443
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Set ams client to null if any of their properties are null.
>
> Its already merged/fixed in 2.6 branch
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java f446446
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java 1094852
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetricsManagerTest.java 24042a7
>
>
> Diff: https://reviews.apache.org/r/63803/diff/1/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Oliver Szabo
>
>