You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/24 07:41:09 UTC

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #180: [FLINK-30159] Add Transformer for ANOVATest

jiangxin369 commented on code in PR #180:
URL: https://github.com/apache/flink-ml/pull/180#discussion_r1031142739


##########
flink-ml-python/pyflink/ml/lib/tests/test_ml_lib_completeness.py:
##########
@@ -140,6 +145,11 @@ def module(self):
         from pyflink.ml.lib import stats
         return stats
 
+    def exclude_java_stage(self) -> List[str]:
+        return [
+            "org.apache.flink.ml.stats.anovatest.ANOVATest",

Review Comment:
   We can simplify it to `"anovatest.ANOVATest"` but not `"ANOVATest"`, because it is not required to keep the package name equalsIgnoreCase the class name, that's why we have both `_java_transformer_package_name` and `_java_transformer_class_name` in  class `JavaFeatureTransformer`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org