You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/05/22 04:55:36 UTC

[PR] Revert JLine from 4.1.0 to 4.0.15 to fix camel shell immediate exit [camel]

gnodet opened a new pull request, #23446:
URL: https://github.com/apache/camel/pull/23446

   ## Summary
   
   - Reverts JLine from 4.1.0 to 4.0.15 to fix `camel shell` exiting immediately after printing the banner.
   
   ## Root cause
   
   JLine 4.1.0 introduced `AbstractUnixSysTerminal`, which bypasses the PTY abstraction and reads directly from `new FileInputStream(FileDescriptor.in)`. Combined with a latent bug in `enterRawMode()` that sets `VMIN=0, VTIME=1` (instead of the POSIX `cfmakeraw` defaults `VMIN=1, VTIME=0`), the kernel returns 0 bytes from `read()` after 100ms idle. Java's `FileInputStream.read()` translates a 0-byte return into `-1` (EOF), causing JLine's `readLine()` to throw `EndOfFileException` and the shell REPL to exit silently.
   
   JLine 4.0.15 uses PTY-backed I/O (`pty.getSlaveInput()`) which handles 0-byte returns correctly, so the shell works as expected.
   
   The upstream fix is in [JLine PR #1871](https://github.com/jline/jline3/pull/1871) (`VMIN=1, VTIME=0`) but has not been released yet. Once a JLine release includes this fix, we can upgrade again.
   
   ## Test plan
   
   - [x] `camel shell` stays open and accepts commands (tested with both 4.0.15 and the SNAPSHOT with the fix)
   - [ ] CI passes
   
   _Claude Code on behalf of Guillaume Nodet_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert JLine from 4.1.0 to 4.0.15 to fix camel shell immediate exit [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #23446:
URL: https://github.com/apache/camel/pull/23446#issuecomment-4515124325

   just note deprendabot will keep raising PRs so we need to deny those until a working 4.1.x is released


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert JLine from 4.1.0 to 4.0.15 to fix camel shell immediate exit [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23446:
URL: https://github.com/apache/camel/pull/23446#issuecomment-4515100741

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert JLine from 4.1.0 to 4.0.15 to fix camel shell immediate exit [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23446:
URL: https://github.com/apache/camel/pull/23446#issuecomment-4515230812

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `parent`
   
   :white_check_mark: **POM dependency changes: targeted tests included**
   
   Changed properties: jline-version
   
   <details><summary>Modules affected by dependency changes (1)</summary>
   
   - `:camel-diagram`
   
   </details>
   
   <details><summary>All tested modules (2 modules)</summary>
   
   - Camel :: Diagram
   - Camel :: Parent
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26269225165)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert JLine from 4.1.0 to 4.0.15 to fix camel shell immediate exit [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #23446:
URL: https://github.com/apache/camel/pull/23446


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org