You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "dan f (JIRA)" <ji...@apache.org> on 2010/11/02 21:36:32 UTC

[jira] Created: (HIVE-1763) drop table (or view) should issue warning if table doesn't exist

drop table (or view) should issue warning if table doesn't exist
----------------------------------------------------------------

                 Key: HIVE-1763
                 URL: https://issues.apache.org/jira/browse/HIVE-1763
             Project: Hive
          Issue Type: Improvement
          Components: Metastore
            Reporter: dan f
            Priority: Minor


drop table reports "OK" even if the table doesn't exist.  Better to report something like mysql's "Unknown table 'foo'" so that, e.g., unwanted tables (especially ones with names prone to typos) don't persist.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1763) drop table (or view) should issue warning if table doesn't exist

Posted by "Paul Butler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Butler updated HIVE-1763:
------------------------------

    Assignee: Paul Butler

> drop table (or view) should issue warning if table doesn't exist
> ----------------------------------------------------------------
>
>                 Key: HIVE-1763
>                 URL: https://issues.apache.org/jira/browse/HIVE-1763
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: dan f
>            Assignee: Paul Butler
>            Priority: Minor
>         Attachments: HIVE-1763.patch
>
>
> drop table reports "OK" even if the table doesn't exist.  Better to report something like mysql's "Unknown table 'foo'" so that, e.g., unwanted tables (especially ones with names prone to typos) don't persist.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1763) drop table (or view) should issue warning if table doesn't exist

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968835#action_12968835 ] 

Namit Jain commented on HIVE-1763:
----------------------------------

However, it will need a lot of test result files to be updated.
Most of the tests will break

> drop table (or view) should issue warning if table doesn't exist
> ----------------------------------------------------------------
>
>                 Key: HIVE-1763
>                 URL: https://issues.apache.org/jira/browse/HIVE-1763
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: dan f
>            Assignee: Paul Butler
>            Priority: Minor
>         Attachments: HIVE-1763.patch
>
>
> drop table reports "OK" even if the table doesn't exist.  Better to report something like mysql's "Unknown table 'foo'" so that, e.g., unwanted tables (especially ones with names prone to typos) don't persist.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1763) drop table (or view) should issue warning if table doesn't exist

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-1763:
-----------------------------

    Status: Open  (was: Patch Available)

> drop table (or view) should issue warning if table doesn't exist
> ----------------------------------------------------------------
>
>                 Key: HIVE-1763
>                 URL: https://issues.apache.org/jira/browse/HIVE-1763
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: dan f
>            Assignee: Paul Butler
>            Priority: Minor
>         Attachments: HIVE-1763.patch
>
>
> drop table reports "OK" even if the table doesn't exist.  Better to report something like mysql's "Unknown table 'foo'" so that, e.g., unwanted tables (especially ones with names prone to typos) don't persist.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1763) drop table (or view) should issue warning if table doesn't exist

Posted by "Paul Butler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Butler updated HIVE-1763:
------------------------------

    Attachment: HIVE-1763.patch

> drop table (or view) should issue warning if table doesn't exist
> ----------------------------------------------------------------
>
>                 Key: HIVE-1763
>                 URL: https://issues.apache.org/jira/browse/HIVE-1763
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: dan f
>            Priority: Minor
>         Attachments: HIVE-1763.patch
>
>
> drop table reports "OK" even if the table doesn't exist.  Better to report something like mysql's "Unknown table 'foo'" so that, e.g., unwanted tables (especially ones with names prone to typos) don't persist.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1763) drop table (or view) should issue warning if table doesn't exist

Posted by "Paul Butler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966367#action_12966367 ] 

Paul Butler commented on HIVE-1763:
-----------------------------------

I was concerned about breaking DROP TABLE's idempotence, so rather than throwing an exception I just print the error to the console. If someone can suggest a better approach I'll do it.

> drop table (or view) should issue warning if table doesn't exist
> ----------------------------------------------------------------
>
>                 Key: HIVE-1763
>                 URL: https://issues.apache.org/jira/browse/HIVE-1763
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: dan f
>            Priority: Minor
>         Attachments: HIVE-1763.patch
>
>
> drop table reports "OK" even if the table doesn't exist.  Better to report something like mysql's "Unknown table 'foo'" so that, e.g., unwanted tables (especially ones with names prone to typos) don't persist.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1763) drop table (or view) should issue warning if table doesn't exist

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968612#action_12968612 ] 

Namit Jain commented on HIVE-1763:
----------------------------------

+1

The approach looks fine

> drop table (or view) should issue warning if table doesn't exist
> ----------------------------------------------------------------
>
>                 Key: HIVE-1763
>                 URL: https://issues.apache.org/jira/browse/HIVE-1763
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: dan f
>            Assignee: Paul Butler
>            Priority: Minor
>         Attachments: HIVE-1763.patch
>
>
> drop table reports "OK" even if the table doesn't exist.  Better to report something like mysql's "Unknown table 'foo'" so that, e.g., unwanted tables (especially ones with names prone to typos) don't persist.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1763) drop table (or view) should issue warning if table doesn't exist

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968855#action_12968855 ] 

John Sichi commented on HIVE-1763:
----------------------------------

See HIVE-1542 for my suggested approach.


> drop table (or view) should issue warning if table doesn't exist
> ----------------------------------------------------------------
>
>                 Key: HIVE-1763
>                 URL: https://issues.apache.org/jira/browse/HIVE-1763
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: dan f
>            Assignee: Paul Butler
>            Priority: Minor
>         Attachments: HIVE-1763.patch
>
>
> drop table reports "OK" even if the table doesn't exist.  Better to report something like mysql's "Unknown table 'foo'" so that, e.g., unwanted tables (especially ones with names prone to typos) don't persist.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1763) drop table (or view) should issue warning if table doesn't exist

Posted by "Paul Butler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Butler updated HIVE-1763:
------------------------------

    Status: Patch Available  (was: Open)

> drop table (or view) should issue warning if table doesn't exist
> ----------------------------------------------------------------
>
>                 Key: HIVE-1763
>                 URL: https://issues.apache.org/jira/browse/HIVE-1763
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: dan f
>            Assignee: Paul Butler
>            Priority: Minor
>         Attachments: HIVE-1763.patch
>
>
> drop table reports "OK" even if the table doesn't exist.  Better to report something like mysql's "Unknown table 'foo'" so that, e.g., unwanted tables (especially ones with names prone to typos) don't persist.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.