You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/11/12 08:22:52 UTC
[GitHub] [james-project] ottoka opened a new pull request #746: JAMES-3669 Delay on authentication failure
ottoka opened a new pull request #746:
URL: https://github.com/apache/james-project/pull/746
For standalone James installations, there should be some basic protection against people/bots abusing James as a password oracle for brute-force/dictionary attacks. This needs to be enforced in a central location, so it affects all of the various protocols supported by James.
This proposal adds an option verifyFailureDelay to usersrepository.xml, which delays the response if someone tries to authenticate with a non-existing user or wrong password. There is intentionally no distinction between these two cases, so it also covers username guessing attacks.
Introducing this feature should not affect existing James installations, so the default is 0 delay/disabled.
T-Shirt size S.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ottoka commented on a change in pull request #746: JAMES-3669 Delay on authentication failure
Posted by GitBox <gi...@apache.org>.
ottoka commented on a change in pull request #746:
URL: https://github.com/apache/james-project/pull/746#discussion_r748076996
##########
File path: server/apps/distributed-app/docs/modules/ROOT/pages/configure/usersrepository.adoc
##########
@@ -36,6 +36,9 @@ recipient local part than as login for different protocols.
|user's name. Allow a user to access to the https://tools.ietf.org/html/rfc4616#section-2[impersonation command],
acting on the behalf of any user.
+| verifyFailureDelay
+| Delay after a failed authentication attempt with an invalid user name or password. Duration string defaulting to seconds. No delay if 0 or omitted.
Review comment:
Pushed, hope this is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #746: JAMES-3669 Delay on authentication failure
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #746:
URL: https://github.com/apache/james-project/pull/746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #746: JAMES-3669 Delay on authentication failure
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #746:
URL: https://github.com/apache/james-project/pull/746#discussion_r748063275
##########
File path: server/apps/distributed-app/docs/modules/ROOT/pages/configure/usersrepository.adoc
##########
@@ -36,6 +36,9 @@ recipient local part than as login for different protocols.
|user's name. Allow a user to access to the https://tools.ietf.org/html/rfc4616#section-2[impersonation command],
acting on the behalf of any user.
+| verifyFailureDelay
+| Delay after a failed authentication attempt with an invalid user name or password. Duration string defaulting to seconds. No delay if 0 or omitted.
Review comment:
Also add this property within `src/site/xdoc/server/config-usersrepository.xml`...
##########
File path: server/apps/distributed-app/docs/modules/ROOT/pages/configure/usersrepository.adoc
##########
@@ -36,6 +36,9 @@ recipient local part than as login for different protocols.
|user's name. Allow a user to access to the https://tools.ietf.org/html/rfc4616#section-2[impersonation command],
acting on the behalf of any user.
+| verifyFailureDelay
+| Delay after a failed authentication attempt with an invalid user name or password. Duration string defaulting to seconds. No delay if 0 or omitted.
Review comment:
Please indicate units being used, which unit is used if none is specified, and also what is the default value (`0`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ottoka commented on a change in pull request #746: JAMES-3669 Delay on authentication failure
Posted by GitBox <gi...@apache.org>.
ottoka commented on a change in pull request #746:
URL: https://github.com/apache/james-project/pull/746#discussion_r748070928
##########
File path: server/apps/distributed-app/docs/modules/ROOT/pages/configure/usersrepository.adoc
##########
@@ -36,6 +36,9 @@ recipient local part than as login for different protocols.
|user's name. Allow a user to access to the https://tools.ietf.org/html/rfc4616#section-2[impersonation command],
acting on the behalf of any user.
+| verifyFailureDelay
+| Delay after a failed authentication attempt with an invalid user name or password. Duration string defaulting to seconds. No delay if 0 or omitted.
Review comment:
Uh, it does say all these things...? But maybe some examples would be more helpful. i.e.: 2, 2s, 2000ms
And of course I always forget about the other documentation location...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #746: JAMES-3669 Delay on authentication failure
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #746:
URL: https://github.com/apache/james-project/pull/746#discussion_r748078855
##########
File path: server/apps/distributed-app/docs/modules/ROOT/pages/configure/usersrepository.adoc
##########
@@ -36,6 +36,9 @@ recipient local part than as login for different protocols.
|user's name. Allow a user to access to the https://tools.ietf.org/html/rfc4616#section-2[impersonation command],
acting on the behalf of any user.
+| verifyFailureDelay
+| Delay after a failed authentication attempt with an invalid user name or password. Duration string defaulting to seconds, e.g. `2`, `2s`, `2000ms`. Default `0s`.
Review comment:
```suggestion
| Delay after a failed authentication attempt with an invalid user name or password. Duration string defaulting to seconds, e.g. `2`, `2s`, `2000ms`. Default `0s`, which disables the feature.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] ottoka commented on a change in pull request #746: JAMES-3669 Delay on authentication failure
Posted by GitBox <gi...@apache.org>.
ottoka commented on a change in pull request #746:
URL: https://github.com/apache/james-project/pull/746#discussion_r748082888
##########
File path: server/apps/distributed-app/docs/modules/ROOT/pages/configure/usersrepository.adoc
##########
@@ -36,6 +36,9 @@ recipient local part than as login for different protocols.
|user's name. Allow a user to access to the https://tools.ietf.org/html/rfc4616#section-2[impersonation command],
acting on the behalf of any user.
+| verifyFailureDelay
+| Delay after a failed authentication attempt with an invalid user name or password. Duration string defaulting to seconds, e.g. `2`, `2s`, `2000ms`. Default `0s`.
Review comment:
Makes sense. I will put (disabled) there, and also in the xdoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org