[Bug 53365] JSR223TestElement should cache ScriptEngineManager

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53365

--- Comment #6 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Created attachment 29038
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29038&action=edit
Path caching ScriptEngineManager

Here is the first step which does the following:
- It creates the ScripEngineManager as a Singleton
- It doesn't store in ScripEngineManager any variables anymore, it stores them
in ScripEngine instead


Regarding backward compatibility:
- It removes getManager protected method and initManager
- It changes processFileOrScript signature
- It also changes scope of variables that were previously stored in
ScripEngineManager

I made comparisons with attached Test Plan and it gives the following:
- JMeter 2.7 : 77 samples/sec
- ScriptEngineManager as instance variable of JSR223TestElement created once:
80 samples/sec
- This version 93.8 samples/sec


Regarding strange memory behaviour, it is strange but there is no leak, memory
drops down although impacting performance in all cases.

In my understanding ScripEngineManager is thread safe.
Is it OK for you if I commit these changes ?


Regards
Philippe M.

-- 
You are receiving this mail because:
You are the assignee for the bug.